Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Passing arguments to the constructor results in an error #2714

Merged

Conversation

g2-ochiai-yuta
Copy link
Contributor

@g2-ochiai-yuta g2-ochiai-yuta commented Aug 24, 2022

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
NullReferenceException is raised because the cts variable is not initialized.

Which issue(s) this PR fixes:

Closes # #2713

Special notes for your reviewer:

NullReferenceException is raised because the cts variable is not initialized.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 434e9a78-974e-4184-ab4b-8967f406232b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2714/head:pr_2714 && git checkout pr_2714
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-fc294c1-amd64

@SaitejaTamma SaitejaTamma added the kind/bug These are bugs. label Aug 24, 2022
@roberthbailey
Copy link
Member

Can you add a unit test that shows the fix (e.g. that would throw the NullReferenceException without your change to the source files but passes with them)? Having a test will prevent any regressions in the future.

@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Aug 24, 2022
@g2-ochiai-yuta
Copy link
Contributor Author

@roberthbailey
I added unit test.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: faa01fbc-6096-450c-8278-4f53c82f4f52

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2714/head:pr_2714 && git checkout pr_2714
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-702b317-amd64

@roberthbailey
Copy link
Member

Thanks!

I've verified by running make test-sdk SDK_FOLDER=csharp that without the change the test fails. :)

@google-oss-prow google-oss-prow bot added the lgtm label Aug 24, 2022
@roberthbailey roberthbailey merged commit 2147520 into googleforgames:main Aug 24, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g2-ochiai-yuta, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants