-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Passing arguments to the constructor results in an error #2714
Bug: Passing arguments to the constructor results in an error #2714
Conversation
NullReferenceException is raised because the cts variable is not initialized.
Build Succeeded 👏 Build Id: 434e9a78-974e-4184-ab4b-8967f406232b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Can you add a unit test that shows the fix (e.g. that would throw the NullReferenceException without your change to the source files but passes with them)? Having a test will prevent any regressions in the future. |
@roberthbailey |
Build Succeeded 👏 Build Id: faa01fbc-6096-450c-8278-4f53c82f4f52 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Thanks! I've verified by running |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g2-ochiai-yuta, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / Why we need it:
NullReferenceException is raised because the cts variable is not initialized.
Which issue(s) this PR fixes:
Closes # #2713
Special notes for your reviewer: