-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing env to flag mapping #2728
Added missing env to flag mapping #2728
Conversation
On the allocator the following mapping were missing: REMOTE_ALLOCATION_TIMEOUT TOTAL_REMOTE_ALLOCATION_TIMEOUT ALLOCATION_BATCH_WAIT_TIME On the controller the following mapping was missing: ALLOCATION_BATCH_WAIT_TIME
/assign @roberthbailey |
Build Succeeded 👏 Build Id: 6699a067-13c0-4ea4-a071-b8472bf677aa The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roberthbailey, valentintorikian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: b1a84c92-b5a1-4b0c-9a2b-5e03a00fdfc7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
On the allocator the following env to config mapping were missing:
REMOTE_ALLOCATION_TIMEOUT
TOTAL_REMOTE_ALLOCATION_TIMEOUT
ALLOCATION_BATCH_WAIT_TIME
On the controller the following mapping was missing:
ALLOCATION_BATCH_WAIT_TIME
The effect is that the value of those flag was completely ignored when parsing the environment and falling back to the default value.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer: