TestGameServerRestartBeforeReadyCrash: Close race #2812
Conversation
This closes the race in googleforgames#2445 by introducing a larger delay before we mark the game server pod as Ready(). This change admits the possibility that in some circumstances, if the game server initializes too quickly and kubelet loses a race to update the pod, we may perceive the game server as having crashed when it did not. Closes googleforgames#2445.
|
Build Succeeded 👏 Build Id: af8f89fb-1e19-46fe-a17e-716124d6d89f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roberthbailey, zmerlynn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: a8faca32-ca62-41ac-9ab3-99bd345533ae The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This closes the race in #2445 by introducing a larger delay before we mark the game server pod as Ready(). This change admits the possibility that in some circumstances, if the game server initializes too quickly and kubelet loses a race to update the pod, we may perceive the game server as having crashed when it did not.
/kind bug
Closes #2445.