Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Allocation query cache #2825

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

markmandel
Copy link
Collaborator

@markmandel markmandel commented Nov 25, 2022

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Been having several conversations around the allocation query cache lately.

People assume that it is strongly consistent, when in fact it is not.

So wanted to write some docs to manage expectations appropriately.

Which issue(s) this PR fixes:

Closes #2788

Special notes for your reviewer:

N/A

Been having several conversations around the allocation query cache
lately.

People assume that it is strongly consistent, when in fact it is not.

So wanted to write some docs to manage expectations appropriately.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 75fc4b43-35e4-4d62-a34b-8ef0bc648a5f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2825/head:pr_2825 && git checkout pr_2825
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-1ad7285-amd64

@markmandel markmandel linked an issue Nov 26, 2022 that may be closed by this pull request
@google-oss-prow google-oss-prow bot removed the lgtm label Nov 29, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e1bb9660-613e-4761-b54c-5e66ce4af143

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2825/head:pr_2825 && git checkout pr_2825
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-4409ec3-amd64

@roberthbailey roberthbailey merged commit 334574e into googleforgames:main Nov 29, 2022
@mangalpalli mangalpalli added this to the 1.28.0 milestone Nov 29, 2022
@markmandel markmandel deleted the docs/allocation-cache branch November 29, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No gameservers available when lots of requests in quick succession
5 participants