Simple Game Server: Add \n to Counters and Lists Response #3589
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -687,8 +687,9 @@ func getCounterCount(s *sdk.SDK, counterName string) (string, error) { | |||||
| count, err := s.Alpha().GetCounterCount(counterName) | ||||||
| if err != nil { | ||||||
| log.Printf("Error getting Counter %s Count: %s", counterName, err) | ||||||
| return strconv.FormatInt(count, 10), err | ||||||
| } | ||||||
| return "COUNTER: " + strconv.FormatInt(count, 10) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // incrementCounter returns the if the Counter Count was incremented successfully (true) or not (false) | ||||||
|
|
@@ -701,8 +702,9 @@ func incrementCounter(s *sdk.SDK, counterName string, amount string) (string, er | |||||
| ok, err := s.Alpha().IncrementCounter(counterName, amountInt) | ||||||
| if err != nil { | ||||||
| log.Printf("Error incrementing Counter %s Count by amount %d: %s", counterName, amountInt, err) | ||||||
| return strconv.FormatBool(ok), err | ||||||
| } | ||||||
| return "SUCCESS: " + strconv.FormatBool(ok) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // decrementCounter returns the if the Counter Count was decremented successfully (true) or not (false) | ||||||
|
|
@@ -715,8 +717,9 @@ func decrementCounter(s *sdk.SDK, counterName string, amount string) (string, er | |||||
| ok, err := s.Alpha().DecrementCounter(counterName, amountInt) | ||||||
| if err != nil { | ||||||
| log.Printf("Error decrementing Counter %s Count by amount %d: %s", counterName, amountInt, err) | ||||||
| return strconv.FormatBool(ok), err | ||||||
| } | ||||||
| return "SUCCESS: " + strconv.FormatBool(ok) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // setCounterCount returns the if the Counter was set to a new Count successfully (true) or not (false) | ||||||
|
|
@@ -729,8 +732,9 @@ func setCounterCount(s *sdk.SDK, counterName string, amount string) (string, err | |||||
| ok, err := s.Alpha().SetCounterCount(counterName, amountInt) | ||||||
| if err != nil { | ||||||
| log.Printf("Error setting Counter %s Count by amount %d: %s", counterName, amountInt, err) | ||||||
| return strconv.FormatBool(ok), err | ||||||
| } | ||||||
| return "SUCCESS: " + strconv.FormatBool(ok) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // getCounterCapacity returns the Capacity of the given Counter as a string | ||||||
|
|
@@ -739,8 +743,9 @@ func getCounterCapacity(s *sdk.SDK, counterName string) (string, error) { | |||||
| count, err := s.Alpha().GetCounterCapacity(counterName) | ||||||
| if err != nil { | ||||||
| log.Printf("Error getting Counter %s Capacity: %s", counterName, err) | ||||||
| return strconv.FormatInt(count, 10), err | ||||||
| } | ||||||
| return "CAPACITY: " + strconv.FormatInt(count, 10) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // setCounterCapacity returns the if the Counter was set to a new Capacity successfully (true) or not (false) | ||||||
|
|
@@ -753,8 +758,9 @@ func setCounterCapacity(s *sdk.SDK, counterName string, amount string) (string, | |||||
| ok, err := s.Alpha().SetCounterCapacity(counterName, amountInt) | ||||||
| if err != nil { | ||||||
| log.Printf("Error setting Counter %s Capacity to amount %d: %s", counterName, amountInt, err) | ||||||
| return strconv.FormatBool(ok), err | ||||||
| } | ||||||
| return "SUCCESS: " + strconv.FormatBool(ok) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // getListCapacity returns the Capacity of the given List as a string | ||||||
|
|
@@ -763,8 +769,9 @@ func getListCapacity(s *sdk.SDK, listName string) (string, error) { | |||||
| capacity, err := s.Alpha().GetListCapacity(listName) | ||||||
| if err != nil { | ||||||
| log.Printf("Error getting List %s Capacity: %s", listName, err) | ||||||
| return strconv.FormatInt(capacity, 10), err | ||||||
| } | ||||||
| return "CAPACITY: " + strconv.FormatInt(capacity, 10) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // setListCapacity returns if the List was set to a new Capacity successfully (true) or not (false) | ||||||
|
|
@@ -777,8 +784,9 @@ func setListCapacity(s *sdk.SDK, listName string, amount string) (string, error) | |||||
| ok, err := s.Alpha().SetListCapacity(listName, amountInt) | ||||||
| if err != nil { | ||||||
| log.Printf("Error setting List %s Capacity to amount %d: %s", listName, amountInt, err) | ||||||
| return strconv.FormatBool(ok), err | ||||||
| } | ||||||
| return "SUCCESS: " + strconv.FormatBool(ok) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // listContains returns true if the given value is in the given List, false otherwise | ||||||
|
|
@@ -787,8 +795,12 @@ func listContains(s *sdk.SDK, listName string, value string) (string, error) { | |||||
| ok, err := s.Alpha().ListContains(listName, value) | ||||||
| if err != nil { | ||||||
| log.Printf("Error getting List %s contains value %s: %s", listName, value, err) | ||||||
| return strconv.FormatBool(ok), err | ||||||
| } | ||||||
| if ok { | ||||||
| return "FOUND: " + strconv.FormatBool(ok) + "\n", nil | ||||||
| } | ||||||
| return "ERROR: " + strconv.FormatBool(ok) + "\n", err | ||||||
| } | ||||||
|
|
||||||
| // getListLength returns the length (number of values) of the given List as a string | ||||||
|
|
@@ -797,8 +809,9 @@ func getListLength(s *sdk.SDK, listName string) (string, error) { | |||||
| length, err := s.Alpha().GetListLength(listName) | ||||||
| if err != nil { | ||||||
| log.Printf("Error getting List %s length: %s", listName, err) | ||||||
| return strconv.Itoa(length), err | ||||||
| } | ||||||
| return "LENGTH: " + strconv.Itoa(length) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // getListValues return the values in the given List as a comma delineated string | ||||||
|
|
@@ -807,8 +820,12 @@ func getListValues(s *sdk.SDK, listName string) (string, error) { | |||||
| values, err := s.Alpha().GetListValues(listName) | ||||||
| if err != nil { | ||||||
| log.Printf("Error getting List %s values: %s", listName, err) | ||||||
| return strings.Join(values, ","), err | ||||||
| } | ||||||
| if len(values) > 0 { | ||||||
| return "VALUES: " + strings.Join(values, ",") + "\n", nil | ||||||
| } | ||||||
| return "Empty List" + strings.Join(values, ",") + "\n", err | ||||||
|
There was a problem hiding this comment. Could you review the getListValues method? I'm unsure if anything is missing. In negative test cases, it only returns 'ERROR:' without further details. Is this behavior expected? There was a problem hiding this comment. It's normal for the examples/simply-game-server/main.go code. This code only sends back the return value, not any return error. And in the case of agones/examples/simple-game-server/main.go Lines 496 to 511 in 1215925 There was a problem hiding this comment.
Suggested change
Or something like that? To be consistent with the other responses of having a "DESCRIPTOR:RESULT" format. There was a problem hiding this comment. The response for the $ nc -u localhost 7654 |
||||||
| } | ||||||
|
|
||||||
| // appendListValue returns if the given value was successfuly added to the List (true) or not (false) | ||||||
|
|
@@ -817,8 +834,9 @@ func appendListValue(s *sdk.SDK, listName string, value string) (string, error) | |||||
| ok, err := s.Alpha().AppendListValue(listName, value) | ||||||
| if err != nil { | ||||||
| log.Printf("Error appending Value %s to List %s: %s", value, listName, err) | ||||||
| return strconv.FormatBool(ok), err | ||||||
| } | ||||||
| return "SUCCESS: " + strconv.FormatBool(ok) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // deleteListValue returns if the given value was successfuly deleted from the List (true) or not (false) | ||||||
|
|
@@ -827,8 +845,9 @@ func deleteListValue(s *sdk.SDK, listName string, value string) (string, error) | |||||
| ok, err := s.Alpha().DeleteListValue(listName, value) | ||||||
| if err != nil { | ||||||
| log.Printf("Error deleting Value %s to List %s: %s", value, listName, err) | ||||||
| return strconv.FormatBool(ok), err | ||||||
| } | ||||||
| return "SUCCESS: " + strconv.FormatBool(ok) + "\n", nil | ||||||
| } | ||||||
|
|
||||||
| // doHealth sends the regular Health Pings | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this review comment got lost somewhere - but this result should be the following.
Not finding a value shouldn't be an error - it's just a search function.