Upgrade to Golang Version 1.22.6 #3985
Conversation
github-actions
bot
added
kind/cleanup
|
Build Failed 😭 Build Id: 4efc66fe-a3c3-4416-8b6f-195c542007f1 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: be240f79-00af-46e3-a33d-a8579e1dfe72 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 0cff3379-f5cf-4b03-9792-05a18dd3bde1 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
There was a problem hiding this comment.
The current build failure on lint might be due to the golangci-lint tool not up-to-date. I checked https://golangci-lint.run/welcome/install/#local-installation and the current version is go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.61.0. Try changing this line again and then run make lint locally to test this. You will see a lot of lint errors complaining missing error checks and unused values. Try fix those lint errors and see if you can eventually make it pass.
There was a problem hiding this comment.
Change this line in the file to use v.1.61.0
RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: 5394b71c-f854-4909-b201-b6bf8c7e7352 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: aacd1a45-f5be-4023-95eb-ab71c00cd454 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: 6886b897-2dbe-4899-89cf-8da57a219a29 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 1d754c2d-3fe2-437b-9b69-0a08ac56fe29 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: 035719ab-cbf0-4d99-8cb3-62e831c04f3b Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: ed524791-2c6b-457a-beb6-98cdbf093078 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: 20dd556b-16cc-4ee9-aabb-51e3ded38b3f Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: f316e79a-1e4d-44e9-9c14-f9bf253bc89c Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: e2b69b3b-bc6b-4885-9949-777fab7619fc Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
closed since #3988 covers this |
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes: #3949
Closes #3949
Special notes for your reviewer: