-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify additional labels for controller and extension pods #4057
Add ability to specify additional labels for controller and extension pods #4057
Conversation
… include label values for controller and extensions
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I legitimately thought that we had this, but appears we do not! 👍🏻
/gcbrun
@@ -167,6 +167,7 @@ The following tables lists the configurable parameters of the Agones chart and t | |||
| `agones.controller.nodeSelector` | Controller [node labels][nodeSelector] for pod assignment | `{}` | | |||
| `agones.controller.tolerations` | Controller [toleration][toleration] labels for pod assignment | `[]` | | |||
| `agones.controller.affinity` | Controller [affinity][affinity] settings for pod assignment | `{}` | | |||
| `agones.controller.labels` | [Labels][labels] added to the Agones controller pods | `{}` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we publish docs on merge, we'll need you to use a feature shortcode to hide these fields until next release.
You will likely have to make a copy of the table for each version (doing this in the middle of a table tends to render badly).
/gcbrun |
Build Succeeded 🥳 Build Id: d9d48f28-6781-4d5c-a225-aabf983e3c39 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
…nder feature shortcode
Hey @markmandel, thanks for your input. |
/gcbrun |
Build Succeeded 🥳 Build Id: c70b0208-51f5-4f41-9e02-b7481fc32b4f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/gcbrun |
Build Succeeded 🥳 Build Id: 4b3d8b5e-3022-414d-9950-189caf9e60c9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
/gcbrun |
Build Succeeded 🥳 Build Id: c4df02bb-8e5e-4e91-a8fc-ee206494e504 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind hotfix
What this PR does / Why we need it:
Adds the ability to define additional pod labels on controller and extension pods.
This is a generally convenient utility, and in our use case, we make use of labels from pods when scraping them with Prometheus.