-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): support dual-stack networking for load balancers #4073
base: main
Are you sure you want to change the base?
feat(helm): support dual-stack networking for load balancers #4073
Conversation
/gcbrun |
Build Succeeded 🥳 Build Id: f4b94cec-bbc6-4dfe-adae-4b78994cf43f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add descriptions in the relevant tables in https://github.com/googleforgames/agones/blob/main/site/content/en/docs/Installation/Install%20Agones/helm.md?plain=1
install/helm/agones/values.yaml
Outdated
# ipFamilyPolicy: RequireDualStack | ||
# ipFamilies: | ||
# - IPv4 | ||
# - IPv6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of commenting out these settings, can we set them to empty values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about setting them to the default values?
ipFamilyPolicy: SingleStack
ipFamilies:
- IPv4
install/helm/agones/values.yaml
Outdated
# ipFamilyPolicy: RequireDualStack | ||
# ipFamilies: | ||
# - IPv4 | ||
# - IPv6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
install/helm/agones/values.yaml
Outdated
# ipFamilyPolicy: RequireDualStack | ||
# ipFamilies: | ||
# - IPv4 | ||
# - IPv6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
781e4bd
to
ac56c52
Compare
PR updated. Descriptions added and empty values set. @gongmax |
ac56c52
to
a04ccc8
Compare
/gcbrun |
Build Failed 😭 Build Id: 47d1c0b1-a0c7-4607-91a0-4271bb652c79 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
/gcbrun |
Build Succeeded 🥳 Build Id: 8b9f66bb-1ba2-47e8-b229-22c69e27546e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sorry for the back and forth. We need to add expiry / publish versions on the documentation so it's only visible in next release. Similar as dc6d4a0#diff-481b1839587cfc3a359e5e82a78b375445ebe75fe39d5c070150bc4f3a2f51adR195. Otherwise, LGTM |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This PR adds support for setting up dual-stack load balancers (IPv4 and IPv6).