Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): support dual-stack networking for load balancers #4073

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bergemalm
Copy link

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

This PR adds support for setting up dual-stack load balancers (IPv4 and IPv6).

@github-actions github-actions bot added kind/feature New features for Agones size/S labels Dec 19, 2024
@gongmax
Copy link
Collaborator

gongmax commented Dec 20, 2024

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: f4b94cec-bbc6-4dfe-adae-4b78994cf43f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4073/head:pr_4073 && git checkout pr_4073
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-781e4bd

Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 189 to 192
# ipFamilyPolicy: RequireDualStack
# ipFamilies:
# - IPv4
# - IPv6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of commenting out these settings, can we set them to empty values?

Copy link
Author

@bergemalm bergemalm Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about setting them to the default values?

  ipFamilyPolicy: SingleStack
  ipFamilies:
  - IPv4

Comment on lines 202 to 205
# ipFamilyPolicy: RequireDualStack
# ipFamilies:
# - IPv4
# - IPv6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Comment on lines 249 to 252
# ipFamilyPolicy: RequireDualStack
# ipFamilies:
# - IPv4
# - IPv6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@bergemalm bergemalm force-pushed the feat/support-dual-stack-lbs branch from 781e4bd to ac56c52 Compare December 20, 2024 22:26
@bergemalm
Copy link
Author

PR updated. Descriptions added and empty values set. @gongmax

@bergemalm bergemalm force-pushed the feat/support-dual-stack-lbs branch from ac56c52 to a04ccc8 Compare December 20, 2024 22:37
@gongmax
Copy link
Collaborator

gongmax commented Dec 21, 2024

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 47d1c0b1-a0c7-4607-91a0-4271bb652c79

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@gongmax
Copy link
Collaborator

gongmax commented Dec 21, 2024

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 8b9f66bb-1ba2-47e8-b229-22c69e27546e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4073/head:pr_4073 && git checkout pr_4073
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-a04ccc8

@gongmax
Copy link
Collaborator

gongmax commented Dec 23, 2024

Sorry for the back and forth. We need to add expiry / publish versions on the documentation so it's only visible in next release. Similar as dc6d4a0#diff-481b1839587cfc3a359e5e82a78b375445ebe75fe39d5c070150bc4f3a2f51adR195. Otherwise, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants