Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2 new flags to control the Helm installation: #533

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Add 2 new flags to control the Helm installation: #533

merged 1 commit into from
Jan 30, 2019

Conversation

bbf
Copy link
Contributor

@bbf bbf commented Jan 30, 2019

  • registerServiceAccounts - Attempt or not to install service accounts (along with RBAC resources)
  • registerWebhooks - Attempt or not to install webhooks

Also, adding the required "agones.crds.install" to crd/gameserverallocation.yaml

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 09203ead-ddc5-4718-bb50-f6e3217fc320

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 83914527-18ec-489f-bbf0-e3845479167d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel
markmandel reviewed Jan 30, 2019
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs documentation 😄

See https://agones.dev/site/docs/contribute/

I would add it here in "New Configuration Features:"

@bbf
Add 2 new flags to control the Helm installation:
cc4346b 
* registerServiceAccounts - Attempt or not to install service accounts (along with RBAC resources)
* registerWebhooks - Attempt or not to install webhooks

Also, adding the required "agones.crds.install" to crd/gameserverallocation.yaml
@bbf bbf force-pushed the marketplace_integration branch from 3f8b298 to cc4346b Compare January 30, 2019 19:57
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f1baf505-98bb-4f4b-b9cc-87b69f8646c6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/533/head:pr_533 && git checkout pr_533
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-cc4346b

markmandel
markmandel approved these changes Jan 30, 2019
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - gives people lot of options of ordering how they install Agones, if they want to pull parts into their own charts, etc.

@markmandel markmandel merged commit 41408c4 into googleforgames:master Jan 30, 2019
@bbf bbf deleted the marketplace_integration branch January 31, 2019 18:55
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/operations Installation, updating, metrics etc labels Feb 5, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bbf @agones-bot @markmandel