Add Node.js SDK and example - closes #538 #581

steven-supersolid · 2019-02-10T21:05:32Z

This includes

Generated SDK pb files
SDK wrapper
Tests
Example project that uses the SDK

The example project was tested using local SDK server

Site documentation has not been added yet

googlebot · 2019-02-10T21:05:34Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

steven-supersolid · 2019-02-10T21:08:42Z

I signed it!

googlebot · 2019-02-10T21:08:44Z

CLAs look good, thanks!

agones-bot · 2019-02-10T21:16:02Z

Build Succeeded 👏

Build Id: cef37619-7c5e-4c29-a216-9befbe3935e3

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-ad87f02
image: gcr.io/agones-images/agones-sdk:0.8.0-ad87f02
image: gcr.io/agones-images/agones-ping:0.8.0-ad87f02
Linux C++ SDK (build: dev): agonessdk-0.8.0-ad87f02-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-ad87f02-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-ad87f02-src.zip
SDK Server: agonessdk-server-0.8.0-ad87f02.zip

A preview of the website (the last 30 builds are retained):

https://ad87f02-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/581/head:pr_581 && git checkout pr_581
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-ad87f02

sdks/nodejs/README.md

sdks/nodejs/package.json

sdks/nodejs/src/agonesSDK.js

markmandel

Looks good (I assume it works 😄) would like to see it integrated into our build tooling though.

sdks/nodejs/README.md

sdks/nodejs/package.json

sdks/nodejs/spec/agonesSDK.spec.js

sdks/nodejs/src/agonesSDK.js

steven-supersolid · 2019-02-14T10:14:28Z

Regarding it working, it works against the local dev server sdk-server.windows.amd64 --local but I've not tried it against our existing project so that would be worth doing. We could also mark as experimental until it has been battle tested. Will take a look at the build tooling too and see if I can figure out how to integrate

markmandel · 2019-02-15T05:03:10Z

Added some notes on build tooling - first step would be generation -- then probably adding the test suite to the make test command. If you have questions, pop into #development.

We will also want to add some docs 😄 to the website as well 📜

But this looks like a good first start!

sdks/nodejs/src/agonesSDK.js

cyriltovena · 2019-02-15T20:38:16Z

This looks good I'll help you get that into our Makefile soon.

sdks/nodejs/lib/sdk_grpc_pb.js

agones-bot · 2019-02-16T23:07:12Z

Build Succeeded 👏

Build Id: 1280cdb3-446e-4146-be80-c8090e46aa24

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-bd5a3d8
image: gcr.io/agones-images/agones-sdk:0.8.0-bd5a3d8
image: gcr.io/agones-images/agones-ping:0.8.0-bd5a3d8
Linux C++ SDK (build: dev): agonessdk-0.8.0-bd5a3d8-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-bd5a3d8-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-bd5a3d8-src.zip
SDK Server: agonessdk-server-0.8.0-bd5a3d8.zip

A preview of the website (the last 30 builds are retained):

https://bd5a3d8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/581/head:pr_581 && git checkout pr_581
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-bd5a3d8

markmandel · 2019-02-21T01:53:08Z

Just touching base - I'm guessing the things that are outstanding are (a) documentation and (b) integration with our build system?

agones-bot · 2019-02-24T15:40:45Z

Build Succeeded 👏

Build Id: 838427a7-5832-4894-b174-e64875fe7e28

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-162545f
image: gcr.io/agones-images/agones-sdk:0.8.0-162545f
image: gcr.io/agones-images/agones-ping:0.8.0-162545f
Linux C++ SDK (build: dev): agonessdk-0.8.0-162545f-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-162545f-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-162545f-src.zip
SDK Server: agonessdk-server-0.8.0-162545f.zip

A preview of the website (the last 30 builds are retained):

https://162545f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/581/head:pr_581 && git checkout pr_581
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-162545f

agones-bot · 2019-02-24T15:45:41Z

Build Succeeded 👏

Build Id: 8e1d8686-c622-42f8-a29c-005458209c89

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-909b3b7
image: gcr.io/agones-images/agones-sdk:0.8.0-909b3b7
image: gcr.io/agones-images/agones-ping:0.8.0-909b3b7
Linux C++ SDK (build: dev): agonessdk-0.8.0-909b3b7-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-909b3b7-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-909b3b7-src.zip
SDK Server: agonessdk-server-0.8.0-909b3b7.zip

A preview of the website (the last 30 builds are retained):

https://909b3b7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/581/head:pr_581 && git checkout pr_581
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-909b3b7

steven-supersolid · 2019-02-24T16:47:47Z

Getting closer now :) I've added some documentation and also had a go at updating make test but not sure how to proceed on this so not committed.

agones-bot · 2019-02-24T16:55:50Z

Build Succeeded 👏

Build Id: 5a6128e5-ec31-454a-a5bc-85ec7e3ad816

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-b967d76
image: gcr.io/agones-images/agones-sdk:0.8.0-b967d76
image: gcr.io/agones-images/agones-ping:0.8.0-b967d76
Linux C++ SDK (build: dev): agonessdk-0.8.0-b967d76-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-b967d76-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-b967d76-src.zip
SDK Server: agonessdk-server-0.8.0-b967d76.zip

A preview of the website (the last 30 builds are retained):

https://b967d76-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/581/head:pr_581 && git checkout pr_581
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-b967d76

site/content/en/docs/Guides/Client SDKs/nodejs.md

markmandel

I think I only found one thing to add - and that's so we can automate the tests.

sdks/nodejs/package.json

sdks/nodejs/spec/agonesSDK.spec.js

agones-bot · 2019-03-02T16:43:47Z

Build Failed 😱

Build Id: 393aae42-c65c-41c0-9050-33c426517dbf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-03-02T17:25:31Z

Build Succeeded 👏

Build Id: d2015911-74b4-4980-9575-1d9a1edf7387

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-32d01d5
image: gcr.io/agones-images/agones-sdk:0.8.0-32d01d5
image: gcr.io/agones-images/agones-ping:0.8.0-32d01d5
Linux C++ SDK (build: dev): agonessdk-0.8.0-32d01d5-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-32d01d5-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-32d01d5-src.zip
SDK Server: agonessdk-server-0.8.0-32d01d5.zip

A preview of the website (the last 30 builds are retained):

https://32d01d5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/581/head:pr_581 && git checkout pr_581
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-32d01d5

markmandel · 2019-03-04T20:26:45Z

This looks great to me! @Kuqd anything you wanted to touch on? (Since I know you were looking at this closely). Otherwise, I say this is good to merge.

markmandel · 2019-03-05T16:29:31Z

@steven-supersolid - this will need to be squashed into a single commit please. But otherwise, I think we are good to merge this!

agones-bot · 2019-03-05T20:54:11Z

Build Succeeded 👏

Build Id: 860e59be-bb1d-4430-8fe1-828f2c7c1ccb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-d19a1e4
image: gcr.io/agones-images/agones-sdk:0.8.0-d19a1e4
image: gcr.io/agones-images/agones-ping:0.8.0-d19a1e4
Linux C++ SDK (build: dev): agonessdk-0.8.0-d19a1e4-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-d19a1e4-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-d19a1e4-src.zip
SDK Server: agonessdk-server-0.8.0-d19a1e4.zip

A preview of the website (the last 30 builds are retained):

https://d19a1e4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/581/head:pr_581 && git checkout pr_581
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-d19a1e4

site/content/en/docs/Guides/Client SDKs/nodejs.md

agones-bot · 2019-03-06T20:08:31Z

Build Succeeded 👏

Build Id: b160c943-4829-4215-ba2a-f3b6b2eec9d1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-887b8d6
image: gcr.io/agones-images/agones-sdk:0.8.0-887b8d6
image: gcr.io/agones-images/agones-ping:0.8.0-887b8d6
Linux C++ SDK (build: dev): agonessdk-0.8.0-887b8d6-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-887b8d6-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-887b8d6-src.zip
SDK Server: agonessdk-server-0.8.0-887b8d6.zip

A preview of the website (the last 30 builds are retained):

https://887b8d6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/581/head:pr_581 && git checkout pr_581
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-887b8d6

markmandel

🚒

Awesome!

agones-bot · 2019-03-06T20:59:11Z

Build Failed 😱

Build Id: 40af02c3-d584-4dd0-a660-406f718e9a25

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-03-06T21:46:48Z

site/content/en/docs/Guides/Client SDKs/nodejs.md

+let result = await agonesSDK.getGameServer();
+```
+
+To get [updates on the backing GameServer]({{< relref "_index.md#watchgameserverfunctiongameserver" >}}) as they happen, call `watchGameServer(callback)`. The callback will be called with a parameter matching the result of `getGameServer()`.


Suggested change

To get [updates on the backing GameServer]({{< relref "_index.md#watchgameserverfunctiongameserver" >}}) as they happen, call `watchGameServer(callback)`. The callback will be called with a parameter matching the result of `getGameServer()`.

To get [updates on the backing GameServer]({{< relref "_index.md#watchgameserver-function-gameserver" >}}) as they happen, call `watchGameServer(callback)`. The callback will be called with a parameter matching the result of `getGameServer()`.

That will fix the test failure, since the anchor is now inline with master.

agones-bot · 2019-03-06T22:40:15Z

Build Succeeded 👏

Build Id: 494afb75-d54a-4949-8f7c-d0681fad4cba

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-8dd6e59
image: gcr.io/agones-images/agones-sdk:0.9.0-8dd6e59
image: gcr.io/agones-images/agones-ping:0.9.0-8dd6e59
Linux C++ SDK (build: dev): agonessdk-0.9.0-8dd6e59-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-8dd6e59-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-8dd6e59-src.zip
SDK Server: agonessdk-server-0.9.0-8dd6e59.zip

A preview of the website (the last 30 builds are retained):

https://8dd6e59-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/581/head:pr_581 && git checkout pr_581
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-8dd6e59

markmandel reviewed Feb 11, 2019

View reviewed changes

sdks/nodejs/README.md Outdated Show resolved Hide resolved

markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Feb 12, 2019

steven-supersolid commented Feb 12, 2019

View reviewed changes

sdks/nodejs/package.json Show resolved Hide resolved

steven-supersolid commented Feb 12, 2019

View reviewed changes

sdks/nodejs/src/agonesSDK.js Outdated Show resolved Hide resolved

steven-supersolid commented Feb 12, 2019

View reviewed changes

sdks/nodejs/src/agonesSDK.js Show resolved Hide resolved

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Feb 13, 2019

markmandel reviewed Feb 14, 2019

View reviewed changes

cyriltovena reviewed Feb 15, 2019

View reviewed changes

sdks/nodejs/src/agonesSDK.js Outdated Show resolved Hide resolved

steven-supersolid commented Feb 16, 2019

View reviewed changes

sdks/nodejs/lib/sdk_grpc_pb.js Outdated Show resolved Hide resolved

markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Feb 21, 2019

steven-supersolid commented Feb 24, 2019

View reviewed changes

site/content/en/docs/Guides/Client SDKs/nodejs.md Outdated Show resolved Hide resolved

markmandel reviewed Feb 26, 2019

View reviewed changes

sdks/nodejs/package.json Show resolved Hide resolved

sdks/nodejs/spec/agonesSDK.spec.js Show resolved Hide resolved

steven-supersolid force-pushed the nodejs branch from 32d01d5 to d19a1e4 Compare March 5, 2019 20:43

markmandel reviewed Mar 6, 2019

View reviewed changes

site/content/en/docs/Guides/Client SDKs/nodejs.md Show resolved Hide resolved

steven-supersolid force-pushed the nodejs branch from d19a1e4 to 887b8d6 Compare March 6, 2019 19:57

markmandel approved these changes Mar 6, 2019

View reviewed changes

markmandel reviewed Mar 6, 2019

View reviewed changes

steven-supersolid added 2 commits March 6, 2019 22:29

Add Node.js SDK, example and docs - closes googleforgames#538

2e002da

Merge remote-tracking branch 'upstream/master' into nodejs

8dd6e59

steven-supersolid force-pushed the nodejs branch from 07ed557 to 8dd6e59 Compare March 6, 2019 22:30

markmandel added this to the 0.9.0 milestone Mar 6, 2019

markmandel merged commit 2344edb into googleforgames:master Mar 6, 2019

steven-supersolid deleted the nodejs branch July 27, 2019 10:15

huan mentioned this pull request Feb 20, 2021

Error: Cannot find module './google/api/annotations_pb.js' wechaty/grpc#113

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Node.js SDK and example - closes #538 #581

Add Node.js SDK and example - closes #538 #581

steven-supersolid commented Feb 10, 2019

googlebot commented Feb 10, 2019

steven-supersolid commented Feb 10, 2019

googlebot commented Feb 10, 2019

agones-bot commented Feb 10, 2019

markmandel left a comment

steven-supersolid commented Feb 14, 2019 •

edited

Loading

markmandel commented Feb 15, 2019

cyriltovena commented Feb 15, 2019

agones-bot commented Feb 16, 2019

markmandel commented Feb 21, 2019

agones-bot commented Feb 24, 2019

agones-bot commented Feb 24, 2019

steven-supersolid commented Feb 24, 2019

agones-bot commented Feb 24, 2019

markmandel left a comment

agones-bot commented Mar 2, 2019

agones-bot commented Mar 2, 2019

markmandel commented Mar 4, 2019

markmandel commented Mar 5, 2019

agones-bot commented Mar 5, 2019

agones-bot commented Mar 6, 2019

markmandel left a comment

agones-bot commented Mar 6, 2019

markmandel Mar 6, 2019

agones-bot commented Mar 6, 2019

	To get [updates on the backing GameServer]({{< relref "_index.md#watchgameserverfunctiongameserver" >}}) as they happen, call `watchGameServer(callback)`. The callback will be called with a parameter matching the result of `getGameServer()`.
	To get [updates on the backing GameServer]({{< relref "_index.md#watchgameserver-function-gameserver" >}}) as they happen, call `watchGameServer(callback)`. The callback will be called with a parameter matching the result of `getGameServer()`.

Add Node.js SDK and example - closes #538 #581

Add Node.js SDK and example - closes #538 #581

Conversation

steven-supersolid commented Feb 10, 2019

googlebot commented Feb 10, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

steven-supersolid commented Feb 10, 2019

googlebot commented Feb 10, 2019

agones-bot commented Feb 10, 2019

markmandel left a comment

Choose a reason for hiding this comment

steven-supersolid commented Feb 14, 2019 • edited Loading

markmandel commented Feb 15, 2019

cyriltovena commented Feb 15, 2019

agones-bot commented Feb 16, 2019

markmandel commented Feb 21, 2019

agones-bot commented Feb 24, 2019

agones-bot commented Feb 24, 2019

steven-supersolid commented Feb 24, 2019

agones-bot commented Feb 24, 2019

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Mar 2, 2019

agones-bot commented Mar 2, 2019

markmandel commented Mar 4, 2019

markmandel commented Mar 5, 2019

agones-bot commented Mar 5, 2019

agones-bot commented Mar 6, 2019

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Mar 6, 2019

markmandel Mar 6, 2019

Choose a reason for hiding this comment

agones-bot commented Mar 6, 2019

steven-supersolid commented Feb 14, 2019 •

edited

Loading