Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation from FleetAllocation #603

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Remove deprecation from FleetAllocation #603

merged 2 commits into from
Feb 20, 2019

Conversation

markmandel
Copy link
Collaborator

Since #600 is in the wings for next release, which is another breaking change, let's keep FleetAllocation stable for another release and mark GameServerAllocation as experimental to manage expectations appropriately.

@markmandel
Remove deprecation from FleetAllocation
f00fa34 
Since googleforgames#600 is in the wings for next release, which is another breaking change,
let's keep FleetAllocation stable for another release and mark
GameServerAllocation as experimental to manage expectations appropriately.
@markmandel markmandel added the kind/documentation Documentation for Agones label Feb 20, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 20, 2019
@markmandel
Copy link
Collaborator Author

/cc @Kuqd @jkowalski - this work for both of you?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0041af50-91fb-4764-b667-6fc43e0880f7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/603/head:pr_603 && git checkout pr_603
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-f00fa34

cyriltovena
cyriltovena approved these changes Feb 20, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e77c771a-3e84-4440-8ca5-d84d32def022

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/603/head:pr_603 && git checkout pr_603
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-bd11abe

@markmandel markmandel merged commit 4ee2602 into googleforgames:master Feb 20, 2019
@markmandel markmandel deleted the rever/deprecated branch February 20, 2019 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
kind/documentation Documentation for Agones
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena