SDK Service Account was Hardcoded #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of agones.serviceaccount.sdk was not propagated down to the creation of the GameServer Pod, so there actually was no way to edit the service account information without Agones breaking. This is now fixed!
markmandel
added
kind/bug
|
Build Failed 😱 Build Id: f7d69588-9a5d-4ca9-8a40-6ebc70bbf52b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: da4df1a6-babf-4c17-8574-d4035b7d3d14 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of agones.serviceaccount.sdk was not propagated down to the creation of the GameServer Pod, so there actually was no way to edit the service account information without Agones breaking.
This is now fixed!