Refactor https server into its own component #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This both cleans up the webhook component, and makes it easier to test, but also sets us up to reuse the https server with the given cert pair -- which we will want to do as we work on googleforgames#536 and setup an api server extension which needs exactly the same self signed certificate setup.
|
Build Succeeded 👏 Build Id: dae791ac-a59b-4375-9aba-4b7c7bb06d17 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
jkowalski
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both cleans up the webhook component, and makes it easier to test, but also sets us up to reuse the https server with the given cert pair -- which we will want to do as we work on #536 and setup an api server extension which needs exactly the same self signed certificate setup.
Also provides some standard middleware for HTTP handlers, logging and tracking 404's (which becomes useful once we have an api extension, and need to debug if users/k8s itself call incorrect urls)