Fix Down Scale on RollingUpdate

[aLekSer]

rollingUpdateActive now returns valid target number of replicas with E2E test.

Fixing #800 Fleet does not scaled down after allocate and edit.

[agones-bot]

Build Failed 😱

Build Id: 1eb92412-a018-4b9e-91eb-836427882de1

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

--- FAIL: TestAutoscalerWebhook (86.13s)
    fleetautoscaler_test.go:326: 
        	Error Trace:	fleetautoscaler_test.go:326
        	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:""}, Status:"Failure", Message:"Operation cannot be fulfilled on fleetautoscalers.stable.agones.dev \"simple-fleet-st6tp-autoscaler\": the object has been modified; please apply your changes to the latest version and try again", Reason:"Conflict", Details:(*v1.StatusDetails)(0xc0003887e0), Code:409}}
        	Test:       	TestAutoscalerWebhook

Is that flakiness, or a result of the change you made?

[aLekSer]

@markmandel make test-e2e succeed when I run it on test-cluster. Need to check one more time.

[markmandel]

Lemme know if you want me to hit retry 👍

[agones-bot]

Build Succeeded 👏

Build Id: f6469c5d-876e-41aa-9883-caab3b92ea94

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.11.0-b865482
• image: gcr.io/agones-images/agones-sdk:0.11.0-b865482
• image: gcr.io/agones-images/agones-ping:0.11.0-b865482
• Linux C++ SDK (build): agonessdk-0.11.0-b865482-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.11.0-b865482.zip

A preview of the website (the last 30 builds are retained):

• https://b865482-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/802/head:pr_802 && git checkout pr_802
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-b865482

[markmandel]

I have to ask 😄 - why do we need this Sleep? Maybe I can help you craft some kind of condition check here?

[aLekSer]

I will think about the condition, simple wait until gss count == 2 did not work.

[aLekSer]

Switched from timer to wait.PollImmediate(). Test is failing on previous version of Fleets controller and reproduces the issue.

[agones-bot]

Build Succeeded 👏

Build Id: ea029181-2534-4d61-850d-45c616976274

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.11.0-f3d8bf8
• image: gcr.io/agones-images/agones-sdk:0.11.0-f3d8bf8
• image: gcr.io/agones-images/agones-ping:0.11.0-f3d8bf8
• Linux C++ SDK (build): agonessdk-0.11.0-f3d8bf8-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.11.0-f3d8bf8.zip

A preview of the website (the last 30 builds are retained):

• https://f3d8bf8-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/802/head:pr_802 && git checkout pr_802
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-f3d8bf8

[markmandel]

Nice! 👍

[agones-bot]

Build Succeeded 👏

Build Id: fb7dac65-418f-4a01-a55e-cf8fbfd61985

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.11.0-2c1ef1a
• image: gcr.io/agones-images/agones-sdk:0.11.0-2c1ef1a
• image: gcr.io/agones-images/agones-ping:0.11.0-2c1ef1a
• Linux C++ SDK (build): agonessdk-0.11.0-2c1ef1a-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.11.0-2c1ef1a.zip

A preview of the website (the last 30 builds are retained):

• https://2c1ef1a-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/802/head:pr_802 && git checkout pr_802
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-2c1ef1a

[lftakakura]

Nice!