Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ SDK: Update the function signature of WatchGameServer to use a const-reference #951

Merged
merged 1 commit into from
Jul 27, 2019
Merged

C++ SDK: Update the function signature of WatchGameServer to use a const-reference #951

merged 1 commit into from
Jul 27, 2019

Conversation

roberthbailey
Copy link
Member

Also update the simple cpp example so that it still compiles.

Fixes #941.

@roberthbailey roberthbailey force-pushed the cpp-watch-gameserver branch from 180791f to 0764004 Compare July 26, 2019 04:36
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7aba4b6c-f97a-4dc1-af78-43ea17eb9997

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-180791f

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 22eda562-774f-4fde-8d13-57757e172e84

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-0764004

@roberthbailey roberthbailey force-pushed the cpp-watch-gameserver branch from 0764004 to c8f6be2 Compare July 26, 2019 07:40
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e54af7dd-8117-4955-9a7c-a4473015e7a8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-c8f6be2

@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
@markmandel
Copy link
Collaborator

@devjgm - I'm assuming this is correct? If so, I'm happy to commit and push through 👍

@roberthbailey roberthbailey force-pushed the cpp-watch-gameserver branch from c8f6be2 to bc80f38 Compare July 27, 2019 03:53
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f87692cb-20f9-4683-afbc-3e65f21346cd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-bc80f38

markmandel
markmandel approved these changes Jul 27, 2019
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@roberthbailey
C++ SDK: Update the function signature of WatchGameServer to use a
e4812f0 
const-reference. Also update the simple cpp example so that it still
compiles.
@roberthbailey roberthbailey force-pushed the cpp-watch-gameserver branch from efc4752 to e4812f0 Compare July 27, 2019 08:28
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2c90eca6-6aef-40d3-b27a-f96ba470e814

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-efc4752

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ac4437d9-63ec-4188-8147-06accc6e9f44

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-e4812f0

@markmandel markmandel merged commit 496aa2e into googleforgames:master Jul 27, 2019
@markmandel markmandel added kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jul 27, 2019
@roberthbailey roberthbailey deleted the cpp-watch-gameserver branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devjgm devjgm devjgm approved these changes

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

C++ SDK: Use const-reference in WatchGameServer
4 participants
@roberthbailey @agones-bot @markmandel @devjgm