Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.js coverage, dependencies and potential issue #954

Merged
merged 1 commit into from
Jul 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/nodejs-simple/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ const AgonesSDK = require('agones');

const agonesSDK = new AgonesSDK();

const connect = async function() {
const connect = async () => {
agonesSDK.watchGameServer((result) => {
console.log("GameServer Update:\n\tname:", result.objectMeta.name, "\n\tstate:", result.status.state);
});
setInterval(() => {
let healthInterval = setInterval(() => {
agonesSDK.health();
console.log('Health ping sent');
}, 20000);
Expand All @@ -37,7 +37,7 @@ const connect = async function() {
await agonesSDK.ready();
console.log('...marked Ready');

var count = 0;
let count = 0;
setInterval(() => {
count = count + 10;
console.log('Running for', count, 'seconds!');
Expand All @@ -55,6 +55,7 @@ const connect = async function() {
}, 100000);
} catch (error) {
console.error(error);
clearInterval(healthInterval);
}
};

Expand Down
8 changes: 7 additions & 1 deletion sdks/nodejs/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
{
"env": {
"es6": true,
"jasmine": true,
"node": true
},
"extends": "eslint:recommended",
"parserOptions": {
"ecmaVersion": 2017
"ecmaVersion": 2018
},
"rules": {
"lines-between-class-members": "error",
"semi": "error",
"space-before-blocks": "error"
}
}
Loading