Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hugo syntax - remove deprecation warning #988

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Fix Hugo syntax - remove deprecation warning #988

merged 2 commits into from
Aug 13, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Aug 9, 2019 •
edited
Loading

Copy hugo-test part site-test as a separate, because test-gen-api-docs (second part of site-test) takes longer and sometimes it is needed to run hugo-test separately.
Get rid of next error message:
WARN 2019/08/09 11:52:37 Page's .Hugo is deprecated and will be removed
in a future release. Use the global hugo function.

Was fixed in original Docsy repo in this PR:
google/docsy#84

@aLekSer
Fix Hugo deprecation warning
89d84ed 
Split hugo-test from test-gen-api-docs which takes longer.
Get rid of next error message:
WARN 2019/08/09 11:52:37 Page's .Hugo is deprecated and will be removed
in a future release. Use the global hugo function.
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5ccac6b1-4b2f-43a8-8023-fb97253cd2df

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator Author

aLekSer commented Aug 9, 2019

E2E tests failed:

Step #17: time="2019-08-09 13:33:07.127" level=info msg="waiting for fleet condition" fleet=simple-fleet-c56c4
Step #17: FAIL
Step #17: time="2019-08-09 13:33:07.248" level=info msg="Cleaning up now."
Step #17: time="2019-08-09 13:33:07.884" level=info msg="Finished cleanup."
Step #17: FAIL	agones.dev/agones/test/e2e	436.747s
Step #17: Makefile:240: recipe for target 'test-e2e' failed

markmandel
markmandel approved these changes Aug 13, 2019
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 13, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f7047402-ae46-4e11-aa86-d9ccda94bae3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c23a8e10-2bab-49d6-acfa-5ad012621f49

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/988/head:pr_988 && git checkout pr_988
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-ce31dbd

@markmandel markmandel merged commit d8dc35d into googleforgames:master Aug 13, 2019
@markmandel markmandel added this to the 1.0 milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aLekSer @agones-bot @markmandel