Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Redis chart to bitnami as update to 12.3.3 #1315

Merged
merged 9 commits into from
Jan 12, 2021

Conversation

HazWard
Copy link
Collaborator

@HazWard HazWard commented Dec 17, 2020

What this PR does / Why we need it:
The Redis chart was transitioned from stable to bitnami (helm/charts#20969) as part of deprecation and the version was bumped to the latest available.

@aLekSer
Copy link
Collaborator

aLekSer commented Jan 4, 2021

Thanks for your PR. New chart is needed to deploy OpenMatch. Previous one caused:

init-sysctl
Image
docker.io/bitnami/minideb:stretch
Status
 Back-off 5m0s restarting failed container=init-sysctl pod=open-match-redis-master-0_open-match(6e18c377-0fad-4d5c-93f5-971a9467071b): CrashLoopBackOff

After applying your change, Redis has started fine.

@Laremere
Copy link

Laremere commented Jan 7, 2021

Fyi, I'm guessing you unchecked maintainers being allowed to add commits? It means that I can't fix This branch is out-of-date with the base branch, so I can't merge it without you updating. Up to you but thought I'd point that out for future PRs.

@HazWard HazWard requested a review from sawagh as a code owner January 11, 2021 21:22
@HazWard
Copy link
Collaborator Author

HazWard commented Jan 11, 2021

I didn't there was a feature to let maintainers add commits, thanks! I bumped the version to the latest again since a new one came out.

@HazWard HazWard changed the title Move the Redis chart to bitnami as update to 12.2.1 Move the Redis chart to bitnami as update to 12.3.3 Jan 11, 2021
@Laremere Laremere merged commit 3a0cd76 into googleforgames:master Jan 12, 2021
@syntxerror syntxerror added this to the v1.2.0 milestone Mar 25, 2021
@syntxerror syntxerror added area/developer-experience This issue impacts developer experience when building a Matchmaker using Open Match area/refinement and removed area/developer-experience This issue impacts developer experience when building a Matchmaker using Open Match labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants