update to google.golang.org/protobuf and deprecation changes #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridulji
requested review from
aLekSer,
HazWard,
calebatwd,
syntxerror,
sawagh,
andrewgrundy and
scosgrave
as code owners
mridulji
added
the
do-not-merge/work-in-progress
andrewgrundy
approved these changes
Jun 27, 2022
mridulji
force-pushed
the
update_golang_protobuf
branch
from
5c3ea8c
to
60f4b3e
Compare
|
@andrewgrundy Hi, I am trying to start developing open-match but need to upgrade toolchains for building on Apple Silicon (arm64) machine. I look forward to your review! |
mridulji
force-pushed
the
update_golang_protobuf
branch
from
45141ae
to
cf9bd0e
Compare
mridulji
force-pushed
the
update_golang_protobuf
branch
from
e485a32
to
bfae0d1
Compare
mridulji
force-pushed
the
update_golang_protobuf
branch
from
d0f076c
to
6e8454d
Compare
mridulji
force-pushed
the
update_golang_protobuf
branch
3 times, most recently
from
53f57ce
to
df6e036
Compare
|
Some snapshots of open-match, demo in action after making golang upgradation changes in this PR. Works well with mm101-tutorial.
|
syntxerror
removed
the
do-not-merge/work-in-progress
mridulji
added
good first issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Update package github.com/golang/protobuf to google.golang.org/protobuf to keep Open Match dependencies up-to-date.
Which issue(s) this PR fixes:
Closes #1443
Special notes for your reviewer:
Tools updates:
protoc v3.19.4
kubectl v1.21.5
golang v1.19.4