Add open-match-override setting #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemurayama
requested review from
aLekSer,
HazWard,
calebatwd,
syntxerror,
sawagh,
andrewgrundy,
scosgrave and
mridulji
as code owners
mridulji
reviewed
Nov 7, 2022
There was a problem hiding this comment.
I think you may also need to change here to mention "enabled". So it will be
{{- if index .Values "open-match-override" "enabled" }}
But are you able to successfully install open-match (by yaml/helm both ways) by the changes you made 🤔 ?
|
Hey @kemurayama, Please let us know if you are able to test the suggested changes or if there is something you need help with. |
mridulji
added
enhancement
|
Hi @mridulji, I've confirmed that I needed to add "enabled" in |
syntxerror
added a commit
that referenced
this pull request
Dec 6, 2022
* Default values of configs (#1508) * setting validation and default values of configs * config check in internal/config package * Add open-match-override setting (#1490) * Add open-match-override setting * Added enabled Co-authored-by: Jon Foust <38893532+syntxerror@users.noreply.github.com> Co-authored-by: Mridul Goswami <mridulgoswami@google.com> * shifted e2e tests to project root (#1481) * release 1.6.0-rc.1 changes * release changes for tutorials * remaining changes Co-authored-by: kemurayama <7068107+kemurayama@users.noreply.github.com> Co-authored-by: Jon Foust <38893532+syntxerror@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Currently, ConfigMap (open-match-override) should be installed via
--set open-match-override.enabled=true.This PR enables users to set
open-match-override.enabledwithvalues.yaml.Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: