Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #670

Merged
merged 8 commits into from
Jan 10, 2023
Merged

Update dependencies #670

merged 8 commits into from
Jan 10, 2023

Conversation

XAMPPRocky
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the size/s label Jan 2, 2023
@XAMPPRocky
Copy link
Collaborator Author

@markmandel It seems that using workspace dependencies breaks some assumptions in the Makefile. It would be nice if we could add support for it, as it simplifies dependency management greatly.

@XAMPPRocky XAMPPRocky mentioned this pull request Jan 2, 2023
Closed
@markmandel
Copy link
Contributor

@markmandel It seems that using workspace dependencies breaks some assumptions in the Makefile. It would be nice if we could add support for it, as it simplifies dependency management greatly.

Oh yeah, it really does. Lemme take a look, I'm sure I can fix it.

markmandel
markmandel reviewed Jan 4, 2023
View reviewed changes
agones/Cargo.toml
base64 = "0.13.0"
k8s-openapi = { version = "0.16.0", features = ["v1_22"] }
kube = { version = "0.76.0", features = ["runtime", "derive"] }
base64.workspace = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is dope. This makes things far less brittle.

markmandel added a commit to markmandel/quilkin that referenced this pull request Jan 4, 2023
@markmandel
Make: package_version less brittle
ca06bb6 
There is no easy / cross platform way to get at the local crate's
version, so we are doing some grepping, since we can assume grep is
installed on local machines.

This change makes the grep pipeline less brittle by looking for the
`name="quilkin"` block first before grepping for the version details.

Unblocks googleforgames#670
@markmandel markmandel mentioned this pull request Jan 4, 2023
Merged
@markmandel markmandel added this to the 0.5.0 milestone Jan 4, 2023
markmandel
markmandel reviewed Jan 5, 2023
View reviewed changes
agones/Cargo.toml Outdated Show resolved Hide resolved
XAMPPRocky pushed a commit that referenced this pull request Jan 5, 2023
@markmandel
Make: package_version less brittle (#675)
51b25a2 
There is no easy / cross platform way to get at the local crate's
version, so we are doing some grepping, since we can assume grep is
installed on local machines.

This change makes the grep pipeline less brittle by looking for the
`name="quilkin"` block first before grepping for the version details.

Unblocks #670
@markmandel
Copy link
Contributor 

thread 'sidecar::tests::gameserver_sidecar' panicked at 'called `Result::unwrap()` on an `Err` value: HyperError(hyper::Error(Connect, Custom { kind: Other, error: Custom { kind: InvalidData, error: UnsupportedNameType } }))', agones/src/lib.rs:119:42
stack backtrace:

I saw the same thing when I tried to move the agones crate to using "rustls-tls I expect my suggested change will fix it though.

XAMPPRocky and others added 2 commits January 5, 2023 19:17
@XAMPPRocky @markmandel
Update agones/Cargo.toml
2adae7c 
Co-authored-by: Mark Mandel <markmandel@google.com>
@XAMPPRocky
Update Cargo.toml
e0714c9
markmandel
markmandel reviewed Jan 5, 2023
View reviewed changes
agones/Cargo.toml Outdated Show resolved Hide resolved
markmandel
markmandel reviewed Jan 5, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@markmandel
Copy link
Contributor

Just gently bumping this - the two items above should make this good to merge.

Once this is done, I'll cut a 0.5.0 release 👍🏻

XAMPPRocky and others added 2 commits January 10, 2023 10:23
@XAMPPRocky @markmandel
Update Cargo.toml
4676e8c 
Co-authored-by: Mark Mandel <markmandel@google.com>
@XAMPPRocky @markmandel
Update agones/Cargo.toml
dd7d3c3 
Co-authored-by: Mark Mandel <markmandel@google.com>
@XAMPPRocky
Copy link
Collaborator Author

@markmandel Sorry, got lost in the shuffle, but also for changes like that, that are a definite improvement to the PR, you're more than welcome to commit the edits directly without needing my approval. 🙂

@XAMPPRocky XAMPPRocky enabled auto-merge (squash) January 10, 2023 09:44
@XAMPPRocky XAMPPRocky merged commit 798ebc7 into main Jan 10, 2023
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 59297cf5-2c24-4954-b0e1-2b8182ed3240

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/670/head:pr_670 && git checkout pr_670
cargo build

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jan 11, 2023
@XAMPPRocky XAMPPRocky deleted the ep/update-deps branch April 25, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@No-ops No-ops Awaiting requested review from No-ops

@rezvaneh rezvaneh Awaiting requested review from rezvaneh

@vallfors vallfors Awaiting requested review from vallfors

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/s
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@XAMPPRocky @markmandel @quilkin-bot