Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent documentation #976

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update agent documentation #976

merged 1 commit into from
Jun 5, 2024

Conversation

XAMPPRocky
Copy link
Collaborator

Removes some outdated terminology and corrects incorrectly calling configuration sources control planes.

Removes some outdated terminology and corrects incorrectly calling configuration sources control planes.
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 1ec0041b-c058-4385-895e-cf5f1a774542

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/976/head:pr_976 && git checkout pr_976
cargo build

@XAMPPRocky XAMPPRocky merged commit b818af1 into main Jun 5, 2024
12 checks passed
XAMPPRocky added a commit that referenced this pull request Jun 10, 2024
Removes some outdated terminology and corrects incorrectly calling configuration sources control planes.
XAMPPRocky added a commit that referenced this pull request Jun 10, 2024
* wip

* Checkpoint

* Ignore for now

* Fixup tests

* Update quilkin

* Cleanup

* Fix formatting

* Simplify apply_delta

* Add example

* Build tooling updates and fixes. (#974)

* Build tooling updates and fixes.

I stared with documenting how to regenerate protos, and found a few
things that were blocking release, and also was just broken.

So this PR includes:

* Documenting how to regenerate protos with `cargo` and `make`.
* `make` targets for generating protobuf
* Fixes and updates for build tooling for release.
* Updates to rust version - which aligns with the available darwin
  builder image tags.
* Replace `live-server` which broke as unmaintained with `browser-sync`
  which is also way better.

* * Fixes for lint issues.

* Rollback to rust 1.77.1

* There's a joseluisq/rust-linux-darwin-builder:1.77.1 image, but no
  1.77.0 image 🤷🏻‍♂️ - so need to update so we can release macos
  binaries.
* Can't upgrade to 1.78.0 because of
  tikv/pprof-rs#232

* Update agent documentation (#976)

Removes some outdated terminology and corrects incorrectly calling configuration sources control planes.

---------

Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
Co-authored-by: Mark Mandel <markmandel@google.com>
@Jake-Shadle Jake-Shadle deleted the XAMPPRocky-patch-1 branch June 26, 2024 05:39
@markmandel markmandel added kind/documentation Improvements or additions to documentation kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Improvements or additions to documentation size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants