Skip to content
This repository has been archived by the owner on Oct 29, 2023. It is now read-only.

Sharded bam writer merge #140

Merged
merged 1 commit into from
Sep 11, 2015

Conversation

iliat
Copy link
Member

@iliat iliat commented Aug 22, 2015

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@iliat iliat force-pushed the sharded-bam-writer-merge branch from c2368e1 to d732124 Compare August 22, 2015 12:24
@googlebot
Copy link

CLAs look good, thanks!

}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extremely minor nit: lots of whitespace changes in here that are not needed

@iliat
Copy link
Member Author

iliat commented Sep 6, 2015

@deflaux @davidadamsphd
Sorry for the late reply - I'm back now, will address the comments and try to get to merge-able state this week.

@iliat iliat force-pushed the sharded-bam-writer-merge branch from d732124 to 44f415c Compare September 6, 2015 23:14
@iliat
Copy link
Member Author

iliat commented Sep 6, 2015

@deflaux I addressed a bunch of comments and added an integration test. PTAL.
I will file issues for subsequent refactoring and improvements.

@deflaux
Copy link
Contributor

deflaux commented Sep 9, 2015

@iliat thanks for those fixes. Please go ahead and file those issues?

@deflaux deflaux assigned davidadamsphd and unassigned deflaux Sep 9, 2015
@iliat
Copy link
Member Author

iliat commented Sep 9, 2015

Already did :)
#141

On Wed, Sep 9, 2015 at 3:08 PM, Nicole Deflaux notifications@github.com
wrote:

@iliat https://github.com/iliat thanks for those fixes. Please go ahead
and file those issues?


Reply to this email directly or view it on GitHub
#140 (comment)
.

@deflaux
Copy link
Contributor

deflaux commented Sep 9, 2015

that's great, thanks!

@iliat
Copy link
Member Author

iliat commented Sep 10, 2015

So @deflaux , ok to merge ?

@deflaux
Copy link
Contributor

deflaux commented Sep 10, 2015

Its okay by me! Not sure if @davidadamsphd had any feedback.

@davidadamsphd
Copy link
Contributor

Overall looks good. No real feedback.

iliat added a commit that referenced this pull request Sep 11, 2015
@iliat iliat merged commit 3206a7b into googlegenomics:master Sep 11, 2015
jiridanek pushed a commit to jiridanek/dataflow-java that referenced this pull request Jan 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants