-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
c2368e1
to
d732124
Compare
CLAs look good, thanks! |
} | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extremely minor nit: lots of whitespace changes in here that are not needed
@deflaux @davidadamsphd |
d732124
to
44f415c
Compare
@deflaux I addressed a bunch of comments and added an integration test. PTAL. |
@iliat thanks for those fixes. Please go ahead and file those issues? |
Already did :) On Wed, Sep 9, 2015 at 3:08 PM, Nicole Deflaux notifications@github.com
|
that's great, thanks! |
So @deflaux , ok to merge ? |
Its okay by me! Not sure if @davidadamsphd had any feedback. |
Overall looks good. No real feedback. |
…erge Sharded bam writer merge
No description provided.