-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this fix for? What is the issue?
pom.xml
Outdated
<pluginExecutionFilter> | ||
<groupId>kr.motd.maven</groupId> | ||
<artifactId>os-maven-plugin</artifactId> | ||
<versionRange>[1.5.0.Final,)</versionRange> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe fixed version is the best option. With concrete version for all deps/plugins you can have reproducible builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what does this CL change about generation?
</execution> | ||
</executions> | ||
</plugin> | ||
<!-- generate protobuffer java classes --> | ||
<!-- Generate protobuffer java stub --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they reallly stubs? Where is the actual generated Java code?
</execution> | ||
</executions> | ||
</plugin> | ||
<!-- generate protobuffer java classes --> | ||
<!-- Generate protobuffer java stub --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the case change your own personal pref? it seems like whoever wrote the comment first had pref for lower case. in general don't create unnecessary churn in CLs, please.
This CL fixes the following:
|
Ok, I understand the issue now but for me this cl is still controversial.You added kind of hack for an eclipse (1 of many IDEs).
|
Well, like it or not, Eclipse still seems to be (by far) the top (java) IDE: https://trends.google.com/trends/explore?geo=US&q=%2Fm%2F01fs1d,%2Fm%2F03v0mn,%2Fm%2F01fchg And I wouldn't say it's a hack, it's an extra configuration for Eclipse. Other than adding a few more jars downloaded by Maven, it has no effect on a console maven build or using with other IDEs.
Idea's Maven integration has less features than Eclipse's, it is basically just calling out to the command line maven utility. According to my tests, it works with the os-detect plugin out of the box, if the developer runs a maven build explicitly from Idea.
Yes, it works, this pom entry has no effect on non-eclipse scenarios.
I don't know, It might be possible, but could be very complicated (m2e maven integration can be configured under .eclipse/plugins/..../../../ configuration files..). With this extra configuration in maven, allowing Eclipse to run this hook my intention is to make it simple and easy for Eclipse users to import and work with this project. In other words, to avoid complicated custom eclipse configurations and detailed instructions. |
Update: There is a good chance that the m2e lifecycle config will be added to the 'os-maven-detect' plugin itself (into its pom.xml), so the users (incl. us) won't need to include it. But it's unsure if it works that way.. See my conversation on the plugin's GH repo here: xolstice/protobuf-maven-plugin#10 (comment) |
No description provided.