Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GoogleMap() content parameter default to {} and make content non-nullable #493

Closed
bubenheimer opened this issue Jan 1, 2024 · 1 comment · Fixed by #521
Closed

Change GoogleMap() content parameter default to {} and make content non-nullable #493

bubenheimer opened this issue Jan 1, 2024 · 1 comment · Fixed by #521
Labels
priority: p4 An issue that should be addressed eventually. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bubenheimer
Copy link
Contributor

GoogleMap() currently uses null for a default content parameter. This seems an unusual approach to me, plus less descriptive than using {} and keeping the parameter non-nullable. It also slightly complicates the implementation, needing a special case for null content.

Instead, use {} and make content non-null. This is in compliance with Google Compose Component API guidelines that favor more descriptive parameter defaults over null defaults.
@bubenheimer bubenheimer added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jan 1, 2024
bubenheimer added a commit to bubenheimer/android-maps-compose that referenced this issue Jan 1, 2024
@bubenheimer
feat!: change GoogleMap() content parameter default to {} and make co…
7d38792 
…ntent non-nullable

Fixes googlemaps#493
bubenheimer added a commit to bubenheimer/android-maps-compose that referenced this issue Jan 1, 2024
@bubenheimer
feat!: change GoogleMap() content parameter default to {} and make co…
63e3381 
…ntent non-nullable

Fixes googlemaps#493
bubenheimer added a commit to bubenheimer/android-maps-compose that referenced this issue Jan 3, 2024
@bubenheimer
feat!: change GoogleMap() content parameter default to {} and make co…
6e694df 
…ntent non-nullable

Fixes googlemaps#493
@kikoso kikoso added priority: p4 An issue that should be addressed eventually. and removed triage me I really want to be triaged. labels Jan 4, 2024
bubenheimer added a commit to bubenheimer/android-maps-compose that referenced this issue Jan 10, 2024
@bubenheimer
feat!: change GoogleMap() content parameter default to {} and make co…
62cb235 
…ntent non-nullable

Fixes googlemaps#493
bubenheimer added a commit to bubenheimer/android-maps-compose that referenced this issue Feb 1, 2024
@bubenheimer
feat!: change GoogleMap() content parameter default to {} and make co…
d8bfa6d 
…ntent non-nullable

Fixes googlemaps#493
@bubenheimer bubenheimer mentioned this issue Feb 1, 2024
Merged
dkhawk pushed a commit that referenced this issue May 7, 2024
@bubenheimer
feat: change GoogleMap() content parameter default to {} and make con…
8e5e3a6 
…tent non-nullable (#521)

Fixes #493

BREAKING CHANGE: Adds optional contentDescriptor parameter to MarkerComposable and AdvancedMarker.  Makes content parameter of GoogleMap non-nullable, but with an empty default value.
googlemaps-bot pushed a commit that referenced this issue May 7, 2024
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
0ee870d 
# [5.0.0](v4.4.2...v5.0.0) (2024-05-07)

### Bug Fixes

* fixed documentation ([#567](#567)) ([31960a2](31960a2))

### Features

* change GoogleMap() content parameter default to {} and make content non-nullable ([#521](#521)) ([8e5e3a6](8e5e3a6)), closes [#493](#493)

### BREAKING CHANGES

* Adds optional contentDescriptor parameter to MarkerComposable and AdvancedMarker.  Makes content parameter of GoogleMap non-nullable, but with an empty default value.
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p4 An issue that should be addressed eventually. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
3 participants
@bubenheimer @kikoso @googlemaps-bot