-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use AGP's managed devices for instrumentation tests #223
base: main
Are you sure you want to change the base?
Conversation
I also get this locally the first run, then it resolves itself. I wonder if a newer AGP would help.. |
You can also look at the Sunflower config (currently disabled) to see what flags you can pass in (perhaps one of those can do the trick). See: https://github.com/android/sunflower/blob/main/.github/workflows/android.yml#L66 |
I'm betting |
Aww. |
Turns out |
And the property seems to not be implemented in AGP 7.2, only 7.3 Need #224. |
a2880eb
to
e4cb9e1
Compare
This change brings in AGP's Managed Devices, setting up a Pixel 5 on API 29 (matching the device declared in the existing GitHub workflow). It also updates the GitHub workflow to run tests on that emulator, removing the dependency on reactivecircus/android-emulator-runner.
The aim is to hopefully have more reproducibility between tests run locally versus on CI. Not sure yet whether this fixes the current flaky test issue.