Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NPE on onClusterItemUpdated #675

Merged
merged 1 commit into from
Mar 23, 2020
Merged

fix: NPE on onClusterItemUpdated #675

merged 1 commit into from
Mar 23, 2020

Conversation

arriolac
Copy link
Contributor

Attempt to fix NPE in onClusterItemUpdated by swapping the method invocation on the ClusterItem vs. the Marker.
This should work since a null check was performed prior to invoking methods on it.

I couldn't quite repro the crash myself (I was modifying ClusteringDemoActivity locally to try to repro) though.

@barbeau if you have any ideas how to repro this I'm happy to check that.

Fixes #673

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #675 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #675   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          71       71           
  Lines        4035     4035           
  Branches      606      606           
=======================================
  Hits         1588     1588           
  Misses       2344     2344           
  Partials      103      103           
Impacted Files Coverage Δ
...ndroid/clustering/view/DefaultClusterRenderer.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb9e1d...fce4d1f. Read the comment docs.

Copy link
Collaborator

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arriolac! Yes, this is the proper fix.

@arriolac arriolac merged commit 9f7b32c into master Mar 23, 2020
@arriolac arriolac deleted the chris/fix/673 branch March 23, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on zoom out. 1.0.2
3 participants