Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactored Geometry models in swift & optional/nullable properties of the recently committed swift class. #485

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

iHackSubhodip
Copy link
Collaborator

List of Refactored Files, Adding Obj-C file for reference:

  1. GMUFeature
  2. GMUGeometryCollection
  3. GMUGroundOverlay
  4. GMUPoint
  5. GMUPolygon
  6. GMUStyleMap

Refactor:

  1. Corrected the class names in code comments, which got missed in last PR.
  2. Refactored optional/nullable properties of the recently committed swift class. (This got missed in the last PR)

…e` properties of the recently committed swift class.
@iHackSubhodip iHackSubhodip requested a review from wangela August 21, 2024 13:48
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with change comment

@iHackSubhodip iHackSubhodip marked this pull request as ready for review August 23, 2024 01:41
@iHackSubhodip iHackSubhodip merged commit 7edccea into feature/Geometry-Swift Aug 23, 2024
5 checks passed
@iHackSubhodip iHackSubhodip deleted the SB/Geometry-Model-Phase-2 branch August 23, 2024 01:41
iHackSubhodip added a commit that referenced this pull request Jan 16, 2025
…eatmap-Geometry-swift` branch. (#525)

* refactor(`feature/Geometry-Swift`): Refactored Geometry models & Protocols in swift. (#484)

* [Code Commit] Added Geometry models in swift.

* refactor(`feature/Geometry-Swift`): Refactored Geometry models & Protocols in swift.

* refactor: Refactored `Geometry` models in swift & `optional`/`nullable` properties of the recently committed swift class. (#485)

* refactor: Refactored Unit Tests for `Geometry` models in swift. (#486)

* refactor: Refactor & Modernised `GMUGeoJSONParser` class of `Geometry` module. (#487)

* refactor: Translate & Modernised `GMUKMLParser` class of `Geometry` module. (#490)

* refactor: Translate & Modernised `GMUKMLParser` class of `Geometry` module.

* refactor: Code Comments modifications.

* refactor: Translate & Modernised `GMUGeometryRenderer` class of `Geometry` module. (#508)

* refactor: Translate & Modernised `GMUGeometryRenderer` class of `Geometry` module.

* refactor: Removed `GMUGeometryRendererTest.swift` class for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants