fix: only use pre-ESM dependencies #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current master breaks since this still is a commonJS package and as such can't require ESM packages like query-string v8+ and retry-axios v3+. To update those dependencies we need to make a major-release where we switch to ESM-only as well.
googlemaps-bot
added a commit
that referenced
this pull request
Oct 9, 2023
### [3.3.40](v3.3.39...v3.3.40) (2023-10-09) ### Bug Fixes * only use pre-ESM dependencies ([#1047](#1047)) ([a0d416b](a0d416b)) ### Miscellaneous Chores * update all dependencies ([#1044](#1044)) ([c5c0990](c5c0990)), closes [#1035](#1035) ### Build System * **deps:** bump retry-axios from 2.6.0 to 3.1.0 ([#1027](#1027)) ([dacfff6](dacfff6))
|
🎉 This PR is included in version 3.3.40 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
usefulthink
added a commit
to usefulthink/google-maps-services-js
that referenced
this pull request
Oct 10, 2023
packages that no longer support commonjs use should never be installed (googlemaps#1047). However, without a failing test, the dependabot PRs will just slip through, so we have to add a test that will fail when import/require of this package won't work.
usefulthink
added a commit
that referenced
this pull request
Oct 10, 2023
packages that no longer support commonjs use should never be installed (#1047). However, without a failing test, the dependabot PRs will just slip through, so we have to add a test that will fail when import/require of this package won't work.
googlemaps-bot
added a commit
that referenced
this pull request
Oct 10, 2023
### [3.3.41](v3.3.40...v3.3.41) (2023-10-10) ### Bug Fixes * add tests to prevent updating to esm-only dependencies ([#1051](#1051)) ([fd95b9c](fd95b9c)), closes [#1047](#1047) ### Build System * **deps-dev:** bump @types/node from 20.8.3 to 20.8.4 ([#1048](#1048)) ([7e6f1ae](7e6f1ae)) * **deps-dev:** bump typedoc from 0.25.1 to 0.25.2 ([#1050](#1050)) ([522b09e](522b09e)) * **deps:** bump retry-axios from 2.6.0 to 3.1.0 ([#1049](#1049)) ([62ed0cd](62ed0cd))
This was referenced Sep 10, 2024
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current master breaks since this still is a commonJS package and as such can't require ESM packages like query-string v8+ and retry-axios v3+.
To update those dependencies we need to make a major-release where we switch to ESM-only as well.