Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @types/google.maps to 3.55.11, add missing properties to InfoWindow and Map #727

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

KrzysztofWelc
Copy link
Contributor

bump @types/google.maps from 3.55.7 to 3.55.11 and adds missing properties to InfoWindow and Map_

I saw there was another pr addressing this issue made some time ago, but it fails on the pipeline, due to missing properties in InfoWindow and Map_ objects. I have fixed everything in this one.

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #711 🦕

Copy link

google-cla bot commented Jul 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@usefulthink
Copy link
Contributor

Thanks for the initiative! It seems the builds are failing due to an alternate npm registry you've been using when installing the new @types/google.maps version (see changes in package-lock.json). Would you be able to fix that?

…dds missing properties to InfoWindow and Map_

Author:    Krzysztof Welc <krzysiekwelc18@gmail.com>
@KrzysztofWelc
Copy link
Contributor Author

Thanks for the initiative! It seems the builds are failing due to an alternate npm registry you've been using when installing the new @types/google.maps version (see changes in package-lock.json). Would you be able to fix that?

fixed

@usefulthink usefulthink changed the title chore(deps-dev): bump @types/google.maps from 3.55.7 to 3.55.11 and adds missing properties to InfoWindow and Map_ chore(deps-dev): bump @types/google.maps to 3.55.11, add missing properties to InfoWindow and Map Jul 23, 2024
@usefulthink usefulthink merged commit a0672cd into googlemaps:main Jul 24, 2024
11 of 14 checks passed
usefulthink added a commit to usefulthink/js-jest-mocks that referenced this pull request Jul 24, 2024
A previous change (googlemaps#727) was accidentally commited with a `chore:` tag,
so it didn't trigger the release-automation. This empty commit should
fix that.
usefulthink added a commit that referenced this pull request Jul 24, 2024
A previous change (#727) was accidentally commited with a `chore:` tag,
so it didn't trigger the release-automation. This empty commit should
fix that.
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
A previous change (#727) was accidentally commited with a `chore:` tag,
so it didn't trigger the release-automation. This empty commit should
fix that. 122497a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typescript errors between @googlemaps/jest-mocks@2.21.4 and @types/google.maps@3.55.8
2 participants