This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Don't share data array between instances. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. It looks like this is your first contribution to a Google open source project, or you're using an email address we haven't seen before. Before proceeding, you'll need to sign the Contributor License Agreement (CLA) below: https://developers.google.com/open-source/cla/individual Once you've done that, please reply here to let us know. |
|
CLA signed. |
|
@devnook Please let me know if you approve. |
|
FYI: CLA signature found. Thanks! |
|
Added internally as b/16375804 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code shared the data array among all the instances of the polymer element. Moot in the case of a singleton, but not the intended behavior.