Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve sample keyword list for vacation calendar #421

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CraigHutchinson
Copy link

@CraigHutchinson CraigHutchinson commented Aug 10, 2023

Description

The sample misses common UK keywords 'holiday', 'time off' and 'annual leave'

Fixes # (issue)

Is it been tested?

  • Development testing done

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have performed a peer-reviewed with team member(s)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@google-cla
Copy link

google-cla bot commented Aug 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 10, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@CraigHutchinson CraigHutchinson force-pushed the CraigHutchinson-patch-1 branch from ec1841f to 713a4af Compare August 10, 2023 12:21
@CraigHutchinson
Copy link
Author

@vinay-google I do not have riughts to set reviewers, cheers.

@vinay-google vinay-google changed the title Vacation-Calendar: Improve sample keyword list chore: Improve sample keyword list for vacation calendar Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants