Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drive.gs Advanced Drive Service samples #433

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

kencenerelli
Copy link
Contributor

@kencenerelli kencenerelli commented Dec 5, 2023

  • Update the samples to work with Drive API v3.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Is it been tested?

  • Development testing done

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have performed a peer-reviewed with team member(s)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

* Update the samples to work with Drive API v3.
if (!folders.items || folders.items.length === 0) {
console.log('No folders found.');
if (!folders.files || folders.files.length === 0) {
console.log('All folders found.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be No since folders.files.length is 0

@vinay-google vinay-google merged commit 82c5c04 into main Dec 11, 2023
21 of 26 checks passed
@vinay-google vinay-google deleted the kencenerelli-launch-bug branch December 11, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants