Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectron Chromedriver Worker Service #10

Merged
merged 47 commits into from
Jan 11, 2022
Merged

Conversation

goosewobbler
Copy link
Owner

@goosewobbler goosewobbler commented Oct 6, 2021

Prototyping a new WDIO service to allow finer grained control over Chromedriver (CD), closer to the original Spectron. Might not be necessary, but branch will be retained regardless.

EDIT: Verified that test bleed is real and not really expected - kind of annoying. Should try again to make this work.

https://webdriver.io/docs/customservices

Pros of this approach

  • Should bring back the original Spectron CD behaviour (ditched in favour of greater WDIO integration)
  • Retains the current level of WDIO integration (a good chunk of the work done so far on this fork)
  • More control over CD
  • Fewer dependencies

Cons of this approach

  • Not (yet) ascertained that we can effectively restart CD between tests with a worker service.
    • If not, we may be able to work with the WDIO guys to get the desired behaviour
  • Not (yet) ascertained that being able to restart CD between tests is actually a show-stopper
  • More code & another package to maintain

Tasks

  • import and convert wdio-chromedriver-service to TS as wdio-spectron-service
  • change wdio-spectron-service to worker service
  • service kills CD process on exit
  • service restarts CD process between tests
  • update wdio-spectron-service units for new behaviour
  • publish wdio-spectron-service on NPM
  • update readme for restart
  • add wdio-spectron-service to WDIO CLI & docs

@goosewobbler goosewobbler merged commit 2b6f793 into master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant