Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brave path for Windows #13

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Add Brave path for Windows #13

merged 1 commit into from
Mar 3, 2021

Conversation

lobre
Copy link
Contributor

@lobre lobre commented Feb 17, 2021

Hello,

I recently switched browsers from Chrome to Brave and I happily discovered glad that the setup of jsonapi was already existing for Linux!

However, when I switched as well on my Windows machine, I was surprised that Brave was not out of the box supported.

I don’t know if there is a reason for not having the same Browser support between Linux / Mac / Windows but I propose to add Brave to the Windows build with that PR.

Tested on my Windows 10 machine.

Have a nice day,
Loric

@lobre lobre force-pushed the brave-windows branch 2 times, most recently from 1a019d0 to 57501cd Compare February 17, 2021 21:06
@lobre
Copy link
Contributor Author

lobre commented Feb 17, 2021

By the way, I cannot figure out how the commit message should be written (I cannot find the exact rule when I check the CommitCheck details in the build).

If you agree to move forward with that PR, can you please guide me on that point?

Thanks a lot.

@Pharb
Copy link
Member

Pharb commented Mar 3, 2021

Hi @lobre, thanks a lot for the contribution!

I don’t know if there is a reason for not having the same Browser support between Linux / Mac / Windows but I propose to add Brave to the Windows build with that PR.

It mainly depends on community contributions. I don't know other contributors who use Brave on Windows.

By the way, I cannot figure out how the commit message should be written (I cannot find the exact rule when I check the CommitCheck details in the build).

Sorry for the confusing rules around commit messages, please see the documentation here: https://github.com/gopasspw/gopass/blob/master/CONTRIBUTING.md#pull-request-checklist

@Pharb Pharb self-requested a review March 3, 2021 11:24
Copy link
Member

@Pharb Pharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my Windows 10 machine.

That's great :D Thanks for testing it!

internal/jsonapi/manifest/setup_windows.go Show resolved Hide resolved
RELEASE_NOTES=n/a

Signed-off-by: Loric <loric.brevet@gmail.com>
@lobre
Copy link
Contributor Author

lobre commented Mar 3, 2021

Hi @Pharb,

I have updated the README.md to include Brave in the list of supported browsers for Windows.

I have also amended by commit to update the commit message and respect the format.

Let me know if there is anything else

Copy link
Member

@Pharb Pharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot!

@Pharb Pharb merged commit ffd4cd8 into gopasspw:main Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants