Trailing whitespace removed when copying password to clipboard

[leandrolanzieri]

Summary

Hi there. I just found that whenever a secret has a trailing whitespace, copying as gopass show -c test_secret doesn't copy the whitespace. Showing the secret without copying prints the secret correctly. Also, intermediate whitespaces work fine.
Is this known / intentional? Perhaps having a trailing whitespace is not an expected use case.

Steps To Reproduce

Create a new secret with a trailing whitespace (e.g., supersecure ). Try copying with gopass show -c test_secret.

Expected behavior

supersecure ends up on the clipboard.

Environment

• OS: Manjaro Linux
• OS version: Linux 5.10.211-1-MANJARO #1 SMP PREEMPT Fri Mar 1 16:55:20 UTC 2024 x86_64 GNU/Linux
• gopass Version: gopass 1.15.11 go1.21.4 linux amd64
• Installation method: yay

[dominikschulz]

Correct. We currently do not support passwords with leading or trailing whitespaces: https://github.com/gopasspw/gopass/blob/master/pkg/gopass/secrets/akv.go#L253

[lhardt]

Since key-value pairs are only key: value, with a single space (see kvSep), it must be fine to remove TrimSpace and just remove the first character instead. Do you mind if I check in a PR for that?

[dominikschulz]

@lhardt That does sound like it shouldn't break any existing workflows that we'd want to support. If you do so please only remove the first character if it's a whitespace. I haven't recently looked at the KV implementation, but we might still support key:value (missing whitespace) and shouldn't break that if we currently do.

[lhardt]

Done :)

See PR #2954

[dominikschulz]

Should be fixed by #2954.

[leandrolanzieri]

Great to see this in!