[CLEANUP] Migration of options to more appropriate sections #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnomalRoil
added
ux
AnomalRoil
force-pushed
the
fix/optionnames
branch
from
223c93f to
99ca261
Compare
This adds an easy migration path to our config handling, which should allow us to migrate option names around much more easily in the future. Any system level config or env variables options are not migrated. This also fixes a bug in our test code, where the root mount path was not properly set in our config, because we used "path:" instead of "path=" to set it. Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
This also makes sure that legacy options aren't used in the code anymore using the docs test and its regexp Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
This is a fun one where if your Timezone isn't UTC and you are past midnight but it's not past midnight UTC, the tests would fail because you're not using the right date to validate it. Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
…he custom Env variables Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
…o GOPASS_CONFIG_KEY_i As discussed in #2617, this actually reflects the way GIT_CONFIG works. It also fixes a potential Panic in our codebase when IsSet was called without any Preset config on a non-existing key. Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
AnomalRoil
force-pushed
the
fix/optionnames
branch
3 times, most recently
from
0609d1c to
8229185
Compare
|
It seems our linter on CI got some new Linters because we're using It seems we also started advertising Go1.21 in our go.mod file, but our CI was still on Go1.20, I've changed it in my last commit. Maybe I should first do another PR with these two CI commits and then rebase this branch on top. What do you prefer @dominikschulz ? |
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
AnomalRoil
force-pushed
the
fix/optionnames
branch
from
f748ecf to
29054e9
Compare
AnomalRoil
changed the title
AnomalRoil
changed the title
|
Splitting off the two huge commits would have been nice, but now that I've made my way through this huge PR we can leave it as is. Thanks a lot, this is a very nice improvement and cleanup effort. |
dominikschulz
previously approved these changes
Nov 2, 2023
dominikschulz
approved these changes
Nov 3, 2023
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
AnomalRoil
force-pushed
the
fix/optionnames
branch
from
42ec61c to
8a97734
Compare
|
I'm always very sad there isn't some kind of global git config option to sign-off commits T.T |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates a few "legacy" options into new config sections, since we didn't have sectioning back when we created these. Namely:
core.showsafecontentshow.safecontentcore.autoclipgenerate.autoclipcore.showautoclipshow.autoclipThis also adds an easy migration path to our config handling, which should allow us to migrate option names around much more easily in the future. I've also tweaked our doc config test to detect legacy options that are still in use.
Any system level config or Env variables options are not migrated.
This also fixes a bug in our test code, where the root mount path was not properly set in our config, because we used "path:" instead of "path=" to set it in our config.
I've also spotted some wild, weird spaces which I've replaced with regular spaces and I've reformatted our markdown tables since I was playing with our documentation. I've also fixed a few typos here and there.
Since we discussed it previously in #2617, this also migrates away from using
GOPASS_CONFIG_CONFIG_VALUE_ninstead ofGOPASS_CONFIG_VALUE_nfor specifying custom options through Env variables, in order to match how GIT_CONFIG works.NB: This is a big PR, but each commit is distinct and I'm happy opening multiple PRs if you prefer.