Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[n/a] Correcting mistake in search+replace #2972

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[n/a] Correcting mistake in search+replace #2972

merged 1 commit into from
Oct 15, 2024

Conversation

AnomalRoil
Copy link
Member

Seems I was a bit hasty when migrating to Go 1.23 and renaming the function "clear" which is now a builtin into "clearClip".

@AnomalRoil
[n/a] Correcting mistake in search+replace
d66d356 
Signed-off-by: Yolan Romailler <AnomalRoil@users.noreply.github.com>
@AnomalRoil AnomalRoil added the cleanup Code hygiene label Oct 15, 2024
dominikschulz
dominikschulz approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I did notice the odd change to some of the debug.Log statements but was assuming those were intentional. The others I did actually miss :/

@dominikschulz dominikschulz merged commit 70c56f9 into master Oct 15, 2024
8 checks passed
@dominikschulz dominikschulz deleted the fix/clearCliptypo branch October 15, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschulz dominikschulz dominikschulz approved these changes

Assignees
No one assigned
Labels
cleanup Code hygiene
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnomalRoil @dominikschulz