chore(deps): bump github.com/twpayne/go-pinentry from v0.3.0 to v4.0.0 #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot. Once the DCO passes that looks like ready to be merged 🙏🏻 |
AnomalRoil
previously approved these changes
Jan 8, 2025
go.sum
Outdated
Comment on lines
194
to
195
| github.com/twpayne/go-pinentry v0.3.0 h1:Rr+fEOZXmeItOb4thjeVaBWJKB9Xa/eojolycyF/26c= | ||
| github.com/twpayne/go-pinentry v0.3.0/go.mod h1:iOIZD+9np/2V24OdCGos7Y1/xX90wc6VEAZsgb+r9D4= | ||
| github.com/twpayne/go-pinentry/v4 v4.0.0 h1:8WcNa+UDVRzz7y9OEEU/nRMX+UGFPCAvl5XsqWRxTY4= | ||
| github.com/twpayne/go-pinentry/v4 v4.0.0/go.mod h1:aXvy+awVXqdH+GS0ddQ7AKHZ3tXM6fJ2NK+e16p47PI= |
There was a problem hiding this comment.
Did you run go mod tidy ? I would have expected the old entry to go away, no?
There was a problem hiding this comment.
No, I explicitly didn't run go mod tidy as it makes a number of other, unrelated, changes to go.sum. I could either leave this as-is, run go mod tidy, or manually edit go.sum to remove the github.com/twpayne/go-pinentry v0.3.0 lines. Which would you prefer?
Edit: s/go.mod/go.sum/
Signed-off-by: Tom Payne <twpayne@gmail.com>
dominikschulz
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is minor, this just updates gopass to use the latest version of go-pinentry.