Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish #179

Merged
merged 12 commits into from Apr 30, 2019
Merged

Publish #179

merged 12 commits into from Apr 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2019

Publish request. Tested on our server.
CreateSubscriptionRequest and MonitoredItemCreateRequest will follow.

@magiconair
Copy link
Member

Thank you. What exactly is your server and can you also provide a working example in the examples folder?

@ghost
Copy link
Author

ghost commented Apr 29, 2019

This is a proprietary server, for our own needs.
Added an example.

Eugene Denisenko added 2 commits April 29, 2019 13:13
@ghost
Copy link
Author

ghost commented Apr 29, 2019

Anything else? Do i need to remove var ... from client.go?

@magiconair
Copy link
Member

In parts this looks a bit like C code ported to Go. I'll do a quick pass and cleanup. Could you re-test after that?

@ghost
Copy link
Author

ghost commented Apr 29, 2019

Yes, no problem.

@magiconair
Copy link
Member

Actually, I can't since I can't push to your branch :( I miss gerrit ...

As for style: lets keep it uniform to simplify code review and keep it in line with other Go code.

client.go Show resolved Hide resolved
@magiconair
Copy link
Member

@wsnotify I've fixed the code a bit and pushed the type switch to the client since it does not make any difference whether you do this in the Publish method or later in the client. But this way the code in client.go is more generic.

@magiconair
Copy link
Member

Also, I'm having some issues checking out your Publish branch. I'm getting into detached head mode. I can make modifications but I'm not sure what happens here. Maybe I'm doing something wrong.

client.go Outdated Show resolved Hide resolved
client.go Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Apr 30, 2019

Tested, works for me.

@magiconair magiconair merged commit 30ab0b8 into gopcua:master Apr 30, 2019
@magiconair magiconair deleted the Publish branch April 30, 2019 08:31
@magiconair
Copy link
Member

Thank you!

@magiconair magiconair added this to the v0.1.0 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants