-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish #179
Publish #179
Conversation
Thank you. What exactly is your server and can you also provide a working example in the |
This is a proprietary server, for our own needs. |
Anything else? Do i need to remove |
In parts this looks a bit like C code ported to Go. I'll do a quick pass and cleanup. Could you re-test after that? |
Yes, no problem. |
Actually, I can't since I can't push to your branch :( I miss gerrit ... As for style: lets keep it uniform to simplify code review and keep it in line with other Go code. |
@wsnotify I've fixed the code a bit and pushed the type switch to the client since it does not make any difference whether you do this in the |
Also, I'm having some issues checking out your |
Tested, works for me. |
Thank you! |
Publish request. Tested on our server.
CreateSubscriptionRequest and MonitoredItemCreateRequest will follow.