Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add method:translate relative path of browse name to node id #237

Merged
merged 4 commits into from
Jul 19, 2019
Merged

add method:translate relative path of browse name to node id #237

merged 4 commits into from
Jul 19, 2019

Conversation

sdghchj
Copy link
Contributor

@sdghchj sdghchj commented Jul 11, 2019 •
edited by magiconair
Loading

Closes #236

@magiconair magiconair added this to the v0.1.3 milestone Jul 11, 2019
alexbrdn
alexbrdn reviewed Jul 11, 2019
View reviewed changes
node.go Outdated Show resolved Hide resolved
@sdghchj
Copy link
Contributor Author

sdghchj commented Jul 11, 2019

@alexbrdn check again

@alexbrdn
Copy link
Collaborator

Code looks OK to me.
Test OK.

@alexbrdn
Copy link
Collaborator

I think it's worth mentioning that this closes #236

magiconair
magiconair reviewed Jul 19, 2019
View reviewed changes
Copy link
Member

@magiconair magiconair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Go style comments. Once fixed we can merge it.

examples/translate/translate.go Show resolved Hide resolved
examples/translate/translate.go Outdated Show resolved Hide resolved
node.go Show resolved Hide resolved
node.go Outdated Show resolved Hide resolved
node.go Show resolved Hide resolved
node.go Outdated Show resolved Hide resolved
node.go Outdated Show resolved Hide resolved
@magiconair
Copy link
Member

This is good enough and thanks for the fast response. I may make some minor tweaks after it is merged.

Thank you for your contribution!

@magiconair magiconair merged commit 59329e8 into gopcua:master Jul 19, 2019
@magiconair magiconair mentioned this pull request Jul 19, 2019
Merged
magiconair added a commit that referenced this pull request Jul 19, 2019
@magiconair
Merge pull request #244 from gopcua/pr-236-followup
569363a 
Follow-up to PR #237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbrdn alexbrdn alexbrdn left review comments

@magiconair magiconair magiconair left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.3
Development

Successfully merging this pull request may close these issues.

How to access a node by StringNodeId ?
3 participants
@sdghchj @alexbrdn @magiconair