Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make counter roll-overs more robust #271

Merged
merged 4 commits into from
Sep 24, 2019
Merged

Make counter roll-overs more robust #271

merged 4 commits into from
Sep 24, 2019

Conversation

magiconair
Copy link
Member

Fixes #189

@magiconair magiconair self-assigned this Sep 16, 2019
@magiconair magiconair mentioned this pull request Sep 16, 2019
Closed
dwhutchison
dwhutchison reviewed Sep 16, 2019
View reviewed changes
Copy link
Collaborator

@dwhutchison dwhutchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

This reminded me that the receiving logic needs to validate the received SequenceNumber. I'll open an issue for that; no need to make this bigger than it needs to be.

@dwhutchison dwhutchison mentioned this pull request Sep 16, 2019
Open
@magiconair magiconair merged commit 44d8b1c into master Sep 24, 2019
@magiconair magiconair deleted the robust-seqnr-clean branch September 24, 2019 17:31
@magiconair magiconair added this to the v0.1.6 milestone Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwhutchison dwhutchison dwhutchison left review comments

Assignees

@magiconair magiconair

Labels
None yet
Projects
None yet
Milestone
v0.1.6
Development

Successfully merging this pull request may close these issues.

Make SequenceNumber counter more robust
2 participants
@magiconair @dwhutchison