Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom timeouts not being utilized from SendRequestWithTimeout #280

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Fix custom timeouts not being utilized from SendRequestWithTimeout #280

merged 2 commits into from
Oct 2, 2019

Conversation

dwhutchison
Copy link
Collaborator

fixes #270

@dwhutchison dwhutchison mentioned this pull request Sep 26, 2019
Closed
@magiconair magiconair added this to the v0.1.6 milestone Sep 26, 2019
@magiconair
Copy link
Member

Do we still need SendAsync after this? I think we can remove it.

@dwhutchison
Copy link
Collaborator Author

Do we still need SendAsync after this? I think we can remove it.

Good catch; I don't see it utilized anymore so I'll remove it.

@magiconair magiconair merged commit 22f9748 into master Oct 2, 2019
@magiconair magiconair deleted the fix/issue-270 branch January 10, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.6
Development

Successfully merging this pull request may close these issues.

The sequence number is unknown to the server. StatusBadSequenceNumberUnknown (0x807A0000)
2 participants
@dwhutchison @magiconair