Skip to content

refactor/tweak SubscriptionParameters usage #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

refactor/tweak SubscriptionParameters usage #321

merged 1 commit into from
Feb 19, 2020

Conversation

kung-foo
Copy link
Member

@kung-foo kung-foo commented Feb 18, 2020 •
edited by magiconair
Loading

  • Exposes opcua.SubscriptionParameters to the monitor function
  • Separates notification channel from SubscriptionParameters

Fixes #320

magiconair
magiconair reviewed Feb 18, 2020
View reviewed changes
Copy link
Member

@magiconair magiconair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magiconair magiconair modified the milestones: v0.1.9, v0.1.10 Feb 18, 2020
@kung-foo kung-foo merged commit f16dc85 into master Feb 19, 2020
@kung-foo kung-foo deleted the fix/issue-320 branch February 19, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magiconair magiconair magiconair left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.10
Development

Successfully merging this pull request may close these issues.

StatusBadSequenceNumberUnknown when subscribing to a node in Kepware
2 participants
@kung-foo @magiconair