ua: ensure variant array dimensions are greater than zero #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All dimensions shall be specified and shall be greater than zero.
|
Where is this in the reference? I can only see that the values need to be greater than zero. Independent of this i think this makes sense and the change LGTM.
|
|
Nvm. I didn't look at the right spot. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the reference, all dimensions shall be specified and shall be greater than zero. So if any dimension is less than 1, return an error.
Fixes #362, because it will ensure that the code bails before trying to split a multi-dimensional array.
What do you think @magiconair?