rework secure channel logic #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kung-foo
force-pushed
the
fix/issue-324-clean
branch
from
86126f3 to
9059bb3
Compare
magiconair
commented
Aug 25, 2020
| @@ -292,6 +292,8 @@ const hdrlen = 8 | |||
| // The size of b must be at least ReceiveBufSize. Otherwise, | |||
| // the function returns an error. | |||
| func (c *Conn) Receive() ([]byte, error) { | |||
| // TODO(kung-foo): allow user-specified buffer | |||
| // TODO(kung-foo): sync.Pool | |||
There was a problem hiding this comment.
beware of sync.Pool since the buffer isn't cleared when it is returned from the pool.
|
@kung-foo is this good to be merged to master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #326 to master. Not yet squashed.
@kung-foo please review and if OK squash it with a sensible commit message.
Should we merge this to master or a release-branch? I'm thinking
mastersince this is latest-and-greatest ... but I don't know whether this patch will break anything.Fixes #324
Closes #326