Fix nil subscription stats to return error #602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nil subscription stats to return error
Bug Report
I'm connecting to KepwareEX V6 with v0.3.5 with a number of subscriptions and calling the experimental feature
StatsWithContext(ctx)
. CallingStatsWithContext
on a BadNodeId subscription is responding with a StatusOK and a nil*ua.Variant
object which then results in a panic as it tries to cast and iterate a slicev.Value().([]*ua.ExtensionObject)
see subscription.go line 311.I expect if the value (
v
set on subscription.go line 306) is empty, it either returns an error stating such, or returns a nil*ua.SubscriptionDiagnosticsDataType
but does not panic.Fix
Add a nil pointer check before casting and iterating the array, returning an error message if the value is empty.
Review Notes
Is there anywhere to document error messages or a style guide for error messages?