Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource provider allocations API for placement #2162

Merged
merged 1 commit into from
May 17, 2021
Merged

Add resource provider allocations API for placement #2162

merged 1 commit into from
May 17, 2021

Conversation

abnvanand
Copy link
Contributor

@abnvanand
Copy link
Contributor Author

Hi @jtopjian. This PR adds API to get allocations for a resource provider.
Can you please review?

Thanks

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 13, 2021

Build succeeded.

@jtopjian
Copy link
Contributor

I think this is the best representation of the schema: https://github.com/openstack/placement/blob/6f00ba5f685183539d0ebf62a4741f2f6930e051/placement/schemas/allocation.py#L75-L126

It also details a project_id and user_id, however, from looking at the acceptance test output, those are not used in the final response.

@jtopjian
Copy link
Contributor

@abnvanand Looks like this needs gofmt run on it. Other than that, this looks good to me and I can merge once that's fixed.

@abnvanand
Copy link
Contributor Author

Fixed formatting.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 17, 2021

Build succeeded.

Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you!

@jtopjian
Copy link
Contributor

@abnvanand Thanks so much for working on this.

@jtopjian jtopjian merged commit cb7437a into gophercloud:master May 17, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 79.877% when pulling 306d9e0 on abnvanand:placement-allocations into 2841b2e on gophercloud:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants