Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octavia: add new pool monitor types #2261

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Nov 5, 2021

resolves #2260

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.862% when pulling 102e0d9 on kayrus:octavia-new-monitors into 3889f57 on gophercloud:master.

@kayrus kayrus changed the title octavia: add new poolmonitor types octavia: add new pool monitor types Nov 5, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 5, 2021

Build failed.

@EmilienM
Copy link
Contributor

EmilienM commented Nov 5, 2021

I confirm that these values are supported by Octavia:
https://github.com/openstack/octavia-lib/blob/master/octavia_lib/common/constants.py#L50-L56

And used by Octavia when creating the listeners.

@EmilienM
Copy link
Contributor

EmilienM commented Nov 5, 2021

this LGTM and safe to land without the acceptance test.
note that this won't work when the backend is OVN, as it doesn't support Health monitors. However, this would return a proper error if anyone tried to created a health monitor when LB is backed by OVN, so nothing to to in Gophercloud I think.
thanks!

@EmilienM EmilienM merged commit 2cf8e4c into gophercloud:master Nov 5, 2021
@kayrus kayrus deleted the octavia-new-monitors branch November 5, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Octavia: add new pool members monitor types
3 participants