details

goplus · Nov 13, 2024 · 5fd419a · 5fd419a
1 parent 0aaf1c1
commit 5fd419a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/spx-gui/src/components/editor/preview/EditorPreview.vue b/spx-gui/src/components/editor/preview/EditorPreview.vue
@@ -10,9 +10,9 @@
     </UICardHeader>
 
     <!--
-      naive-ui Modal does not support feature like `destroyOnClose: false` of antd Modal.
-      To initialize the runner early & only once, we use a hidden container to hold the runner.
-      TODO: use `UIModal` with `destroyOnClose: false` feature.
+      A hidden div is used instead of `UIModal` to initialize the runner early, allowing for flexible preload logic in the runner component.
+      Although naive-ui modal supports `display-directive: show`, it does not initialize the component until it is shown for the first time.
+      TODO: Update `UIModal` to support this requirement.
     -->
     <div class="project-runner-modal" :class="{ visible: running }" :style="modalStyle">
       <RunnerContainer :project="editorCtx.project" :visible="running" @close="running = false" />

diff --git a/spx-gui/vite.config.ts b/spx-gui/vite.config.ts
@@ -45,7 +45,6 @@ export default defineConfig(({ mode }) => {
       },
     },
     vercel: {
-      // TODO: check cache for `public/runner/*`
       // prevent redirection from `/runner/*/runner.html` to `/runner/*/runner`
       cleanUrls: false,
       rewrites: [